OpenVZ Forum


Home » Mailing lists » Devel » [PATCH net-2.6.25 2/2][NEIGH] Use the ctl paths to create neighbours sysctls
Re: [PATCH net-2.6.25 2/2][NEIGH] Use the ctl paths to create neighbours sysctls [message #24123 is a reply to message #24081] Sat, 01 December 2007 13:09 Go to previous message
Herbert Xu is currently offline  Herbert Xu
Messages: 45
Registered: April 2007
Member
On Fri, Nov 30, 2007 at 08:29:16PM +0300, Pavel Emelyanov wrote:
> Since the path is modified, it is put on the stack, to avoid
> possible races with multiple calls to neigh_sysctl_register() : it
> is called by protocols and I didn't find any protection in this
> case. Did I overlooked the rtnl lock?. 

I think the only caller that can be a module is IPv6 :)

> The stack growth of the neigh_sysctl_register() is 40 bytes. I
> believe this is OK, since this is not that much and this function 
> is not called with the deep stack (device/protocols register).

Yes it's fine.

> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

Both applied to net-2.6.25.  Thanks Pavel!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
 
Read Message
Read Message
Previous Topic: [PATCH net-2.6.25 4/6][IPV4] Use ctl paths to register net/ipv4/ table
Next Topic: [PATCH net-2.6.25 5/6][TR] Use ctl paths to register net/token-ring/ table
Goto Forum:
  


Current Time: Mon Mar 04 20:26:37 GMT 2024

Total time taken to generate the page: 0.02744 seconds