OpenVZ Forum

Home » Mailing lists » Devel » [PATCH 2/3] Lost locking in fl6_sock_lookup
Re: [PATCH 2/3] Lost locking in fl6_sock_lookup [message #21999 is a reply to message #21997] Thu, 18 October 2007 12:22 Go to previous messageGo to previous message
Pavel Emelianov is currently offline  Pavel Emelianov
Messages: 1149
Registered: September 2006
Senior Member
David Miller wrote:
> From: Pavel Emelyanov <>
> Date: Thu, 18 Oct 2007 15:53:52 +0400
>> This routine scans the ipv6_fl_list whose update is
>> protected with the socket lock and the ip6_sk_fl_lock.
>> Since the socket lock is not taken in the lookup, use
>> the other one.
>> Signed-off-by: Pavel Emelyanov <>
> Applied.
> But I notice that I was wrong in my email, we don't
> hold the socket lock here.
> What prevents an unlink from the socket's list
> and thus a reference count of zero occurring for
> a brief moment?

Oops. You're right here :( I looked at the ip6_fl_lock
and messed it with the ip6_sk_fl_lock.

Should I resend the whole patch, or just make an 
incremental one?

Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH 3/3] Fix race in ipv6_flowlabel_opt() when inserting two labels
Next Topic: [PATCH] Fix again the fl6_sock_lookup() fixed locking
Goto Forum:

Current Time: Fri Dec 01 05:45:46 GMT 2023

Total time taken to generate the page: 0.06832 seconds