OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 2/3] Lost locking in fl6_sock_lookup
Re: [PATCH 2/3] Lost locking in fl6_sock_lookup [message #21992 is a reply to message #21990] Thu, 18 October 2007 12:00 Go to previous messageGo to previous message
yoshfuji is currently offline  yoshfuji
Messages: 13
Registered: August 2007
Junior Member
In article <47174950.6060409@openvz.org> (at Thu, 18 Oct 2007 15:53:52 +0400), Pavel Emelyanov <xemul@openvz.org> says:

> This routine scans the ipv6_fl_list whose update is
> protected with the socket lock and the ip6_sk_fl_lock.

>  		struct ip6_flowlabel *fl = sfl->fl;
>  		if (fl->label == label) {
> +			read_unlock_bh(&ip6_sk_fl_lock);
>  			fl->lastuse = jiffies;
>  			atomic_inc(&fl->users);
>  			return fl;

We should increment fl->users within the critical section, shouldn't we?

--yoshfuji
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH 3/3] Fix race in ipv6_flowlabel_opt() when inserting two labels
Next Topic: [PATCH] Fix again the fl6_sock_lookup() fixed locking
Goto Forum:
  


Current Time: Fri Dec 01 06:57:11 GMT 2023

Total time taken to generate the page: 0.06802 seconds