OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 3/5][9PFS] Use macro instead of explicit check for mandatory locks
[PATCH 3/5][9PFS] Use macro instead of explicit check for mandatory locks [message #20118] Wed, 12 September 2007 11:23
Pavel Emelianov is currently offline  Pavel Emelianov
Messages: 1149
Registered: September 2006
Senior Member
The __MANDATORY_LOCK(inode) macro makes the same check, but
makes the code more readable.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Ron Minnich <rminnich@sandia.gov>
Cc: Latchesar Ionkov <lucho@ionkov.net>

---

 fs/9p/vfs_file.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index 2a40c29..7e75309 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -105,7 +105,7 @@ static int v9fs_file_lock(struct file *f
 	P9_DPRINTK(P9_DEBUG_VFS, "filp: %p lock: %p\n", filp, fl);
 
 	/* No mandatory locks */
-	if ((inode->i_mode & (S_ISGID | S_IXGRP)) == S_ISGID)
+	if (__MANDATORY_LOCK(inode))
 		return -ENOLCK;
 
 	if ((IS_SETLK(cmd) || IS_SETLKW(cmd)) && fl->fl_type != F_UNLCK) {
 
Read Message
Previous Topic: [PATCH 2/5][GFS2] Use macro instead of explicit check for mandatory locks
Next Topic: [PATCH 4/5][AFS] Use macro instead of explicit check for mandatory locks
Goto Forum:
  


Current Time: Sun Jul 14 00:40:30 GMT 2024

Total time taken to generate the page: 0.02080 seconds