OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.
[PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code. [message #41961] Mon, 01 November 2010 19:35
Jesper Juhl is currently offline  Jesper Juhl
Messages: 7
Registered: October 2010
Junior Member
From: *parallels.com
Hi (please CC me on replies),

In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then
followed by memset() to zero the memory. This can be more efficiently
achieved by using kzalloc() and vzalloc().


Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
memcontrol.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 9a99cfa..90da698 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -4199,14 +4199,13 @@ static struct mem_cgroup *mem_cgroup_alloc(void)

/* Can be very big if MAX_NUMNODES is very big */
if (size < PAGE_SIZE)
- mem = kmalloc(size, GFP_KERNEL);
+ mem = kzalloc(size, GFP_KERNEL);
else
- mem = vmalloc(size);
+ mem = vzalloc(size);

if (!mem)
return NULL;

- memset(mem, 0, size);
mem->stat = alloc_percpu(struct mem_cgroup_stat_cpu);
if (!mem->stat) {
if (size < PAGE_SIZE)


--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Plain text mails only, please http://www.expita.com/nomime.html
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html

_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containe rs
Previous Topic: [PATCH] cgroup: Avoid a memset by using vzalloc
Next Topic: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.
Goto Forum:
  


Current Time: Mon Aug 19 19:15:25 GMT 2019