OpenVZ Forum


Home » Mailing lists » Devel » Re: [PATCH v7 1/3] cgroups: read-write lock CLONE_THREAD forking per threadgroup
Re: [PATCH v7 1/3] cgroups: read-write lock CLONE_THREAD forking per threadgroup [message #41671] Mon, 14 February 2011 05:31
Paul Menage is currently offline  Paul Menage
Messages: 642
Registered: September 2006
Senior Member
From: *parallels.com
On Mon, Jan 24, 2011 at 1:05 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> Risky. sched.h doesn't include rwsem.h.
>
> We could make it do so, but almost every compilation unit in the kernel
> includes sched.h.  It would be nicer to make the kernel build
> finer-grained, rather than blunter-grained.  Don't be afraid to add new
> header files if that is one way of doing this!
>

The only header files included by rwsem.h that aren't directly
included in sched.h already are linux/linkage.h and asm/atomic.h.
Since sighand_struct in sched.h has an atomic_t field, sched.h is
clearly including atomic.h somewhere indirectly. And there are mutex
fields in sched.h, which means it's indirectly including
linux/mutex.h, which includes linux/linkage.h. So I think that it's
hard to argue that this change would make the kernel build any more
heavyweight.

Paul
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containe rs
Previous Topic: cr: fix trivial compile error
Next Topic: [PATCH, v6 1/3] cgroups: export cgroup_iter_{start, next, end}
Goto Forum:
  


Current Time: Sat Jul 21 22:36:50 GMT 2018