OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] Fix again the fl6_sock_lookup() fixed locking
[PATCH] Fix again the fl6_sock_lookup() fixed locking [message #22003] Thu, 18 October 2007 12:36 Go to next message
Pavel Emelianov is currently offline  Pavel Emelianov
Messages: 1149
Registered: September 2006
Senior Member
YOSHIFUJI fairly pointed out, that the users increment should
be done under the ip6_sk_fl_lock not to give IPV6_FL_A_PUT a
chance to put this count to zero and release the flowlabel.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

---

diff --git a/net/ipv6/ip6_flowlabel.c b/net/ipv6/ip6_flowlabel.c
index e55ae1a..b12cc22 100644
--- a/net/ipv6/ip6_flowlabel.c
+++ b/net/ipv6/ip6_flowlabel.c
@@ -210,9 +210,9 @@ struct ip6_flowlabel * fl6_sock_lookup(struct sock *sk, __be32 label)
 	for (sfl=np->ipv6_fl_list; sfl; sfl = sfl->next) {
 		struct ip6_flowlabel *fl = sfl->fl;
 		if (fl->label == label) {
-			read_unlock_bh(&ip6_sk_fl_lock);
 			fl->lastuse = jiffies;
 			atomic_inc(&fl->users);
+			read_unlock_bh(&ip6_sk_fl_lock);
 			return fl;
 		}
 	}
Re: [PATCH] Fix again the fl6_sock_lookup() fixed locking [message #22004 is a reply to message #22003] Thu, 18 October 2007 12:38 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: Pavel Emelyanov <xemul@openvz.org>
Date: Thu, 18 Oct 2007 16:36:58 +0400

> YOSHIFUJI fairly pointed out, that the users increment should
> be done under the ip6_sk_fl_lock not to give IPV6_FL_A_PUT a
> chance to put this count to zero and release the flowlabel.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

Applied, thank you very much Pavel.
Previous Topic: [PATCH 2/3] Lost locking in fl6_sock_lookup
Next Topic: How Inactive may be much greather than cached?
Goto Forum:
  


Current Time: Tue Mar 05 00:31:54 GMT 2024

Total time taken to generate the page: 0.02081 seconds