OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 4/5][AFS] Cleanup explicit check for mandatory locks
[PATCH 4/5][AFS] Cleanup explicit check for mandatory locks [message #20351] Mon, 17 September 2007 07:56
Pavel Emelianov is currently offline  Pavel Emelianov
Messages: 1149
Registered: September 2006
Senior Member
The __mandatory_lock(inode) macro makes the same check, but
makes the code more readable.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: David Howells <dhowells@redhat.com>

---

 fs/afs/flock.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/afs/flock.c b/fs/afs/flock.c
index af6952e..210acaf 100644
--- a/fs/afs/flock.c
+++ b/fs/afs/flock.c
@@ -524,8 +524,7 @@ int afs_lock(struct file *file, int cmd,
 	       (long long) fl->fl_start, (long long) fl->fl_end);
 
 	/* AFS doesn't support mandatory locks */
-	if ((vnode->vfs_inode.i_mode & (S_ISGID | S_IXGRP)) == S_ISGID &&
-	    fl->fl_type != F_UNLCK)
+	if (__mandatory_lock(&vnode->vfs_inode) && fl->fl_type != F_UNLCK)
 		return -ENOLCK;
 
 	if (IS_GETLK(cmd))
Previous Topic: [PATCH 1/5] Cleanup macros for distinguishing mandatory locks
Next Topic: [PATCH 3/5][9PFS] Cleanup explicit check for mandatory locks
Goto Forum:
  


Current Time: Sun Jul 14 00:46:04 GMT 2024

Total time taken to generate the page: 0.02099 seconds