OpenVZ Forum


Home » Mailing lists » Devel » [PATCH RFC] SUNPRC: remove marking service temporary sockets with XPT_CHNGBUF
[PATCH RFC] SUNPRC: remove marking service temporary sockets with XPT_CHNGBUF [message #45006] Fri, 20 January 2012 12:55 Go to next message
Stanislav Kinsbursky is currently offline  Stanislav Kinsbursky
Messages: 683
Registered: October 2011
Senior Member
From: *parallels.com
This is a cleanup patch.
Service temporary sockets can be TCP or RDMA only. But XPT_CHNGBUF service
socket flag is checked only for UDP sockets on receive.
Thus (if I don't miss something non-obvious) this bit raising for temporary
sockets can be removed.

Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>

---
net/sunrpc/svcsock.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index e8af0c9..2867249 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -1381,8 +1381,6 @@ void svc_sock_update_bufs(struct svc_serv *serv)
spin_lock_bh(&serv->sv_lock);
list_for_each_entry(svsk, &serv->sv_permsocks, sk_xprt.xpt_list)
set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
- list_for_each_entry(svsk, &serv->sv_tempsocks, sk_xprt.xpt_list)
- set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
spin_unlock_bh(&serv->sv_lock);
}
EXPORT_SYMBOL_GPL(svc_sock_update_bufs);
Re: [PATCH RFC] SUNPRC: remove marking service temporary sockets with XPT_CHNGBUF [message #45017 is a reply to message #45006] Fri, 20 January 2012 21:40 Go to previous messageGo to next message
Myklebust, Trond is currently offline  Myklebust, Trond
Messages: 52
Registered: November 2011
Member
From: *parallels.com
On Fri, 2012-01-20 at 16:55 +0400, Stanislav Kinsbursky wrote:
> This is a cleanup patch.
> Service temporary sockets can be TCP or RDMA only. But XPT_CHNGBUF service
> socket flag is checked only for UDP sockets on receive.
> Thus (if I don't miss something non-obvious) this bit raising for temporary
> sockets can be removed.
>
> Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
>
> ---
> net/sunrpc/svcsock.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
> index e8af0c9..2867249 100644
> --- a/net/sunrpc/svcsock.c
> +++ b/net/sunrpc/svcsock.c
> @@ -1381,8 +1381,6 @@ void svc_sock_update_bufs(struct svc_serv *serv)
> spin_lock_bh(&serv->sv_lock);
> list_for_each_entry(svsk, &serv->sv_permsocks, sk_xprt.xpt_list)
> set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
> - list_for_each_entry(svsk, &serv->sv_tempsocks, sk_xprt.xpt_list)
> - set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
> spin_unlock_bh(&serv->sv_lock);
> }
> EXPORT_SYMBOL_GPL(svc_sock_update_bufs);

I'm assuming that Bruce will prefer to carry this, since it is
completely orthogonal to the net namespace patchsets.

--
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com
Re: [PATCH RFC] SUNPRC: remove marking service temporary sockets with XPT_CHNGBUF [message #45018 is a reply to message #45006] Fri, 20 January 2012 21:46 Go to previous message
bfields is currently offline  bfields
Messages: 107
Registered: September 2007
Senior Member
From: *parallels.com
On Fri, Jan 20, 2012 at 04:55:39PM +0400, Stanislav Kinsbursky wrote:
> This is a cleanup patch.
> Service temporary sockets can be TCP or RDMA only. But XPT_CHNGBUF service
> socket flag is checked only for UDP sockets on receive.
> Thus (if I don't miss something non-obvious) this bit raising for temporary
> sockets can be removed.

Yes, I believe that's correct, it's leftover cleanup from
9660439861aa8dbd5e2b8087f33e20760c2c9afc "svcrpc: take advantage of tcp
autotuning".

I'll ignore the "RFC" marking and apply unless you tell me otherwise....

--b.

>
> Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
>
> ---
> net/sunrpc/svcsock.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
> index e8af0c9..2867249 100644
> --- a/net/sunrpc/svcsock.c
> +++ b/net/sunrpc/svcsock.c
> @@ -1381,8 +1381,6 @@ void svc_sock_update_bufs(struct svc_serv *serv)
> spin_lock_bh(&serv->sv_lock);
> list_for_each_entry(svsk, &serv->sv_permsocks, sk_xprt.xpt_list)
> set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
> - list_for_each_entry(svsk, &serv->sv_tempsocks, sk_xprt.xpt_list)
> - set_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags);
> spin_unlock_bh(&serv->sv_lock);
> }
> EXPORT_SYMBOL_GPL(svc_sock_update_bufs);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Previous Topic: [PATCH] SUNRPC: search for service transports in network namespace context
Next Topic: [PATCH 0/4] NFS: make internal list network namespace aware
Goto Forum:
  


Current Time: Mon Nov 20 03:57:24 GMT 2017