OpenVZ Forum


Home » Mailing lists » Devel » Re: [PATCH v2 03/13] memcg: Uncharge all kmem when deleting a cgroup.
Re: [PATCH v2 03/13] memcg: Uncharge all kmem when deleting a cgroup. [message #45528] Wed, 14 March 2012 11:59
Glauber Costa is currently offline  Glauber Costa
Messages: 916
Registered: October 2011
Senior Member
From: *parallels.com
>>> @@ -3719,6 +3721,8 @@ move_account:
>>> /* This is for making all *used* pages to be on LRU. */
>>> lru_add_drain_all();
>>> drain_all_stock_sync(memcg);
>>> + if (!free_all)
>>> + memcg_kmem_move(memcg);
>>
>> Any reason we're not moving kmem charges when free_all is set as well?
>
> Because the slab moving code expects to be synchronized with
> allocations (and itself). We can't call it when there are still tasks
> in the cgroup.

Ok.

Please add an explanation about that.
Oh boy, reading it all now, I started to believe that "free_all" is a
really poor name =(
Previous Topic: Re: [PATCH v2 06/13] slab: Add kmem_cache_gfp_flags() helper function.
Next Topic: Re: [PATCH v2 07/13] memcg: Slab accounting.
Goto Forum:
  


Current Time: Sun Feb 23 05:21:12 GMT 2020