OpenVZ Forum


Home » Mailing lists » Devel » Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.
Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code. [message #41902] Wed, 03 November 2010 14:15
Wu Fengguang is currently offline  Wu Fengguang
Messages: 5
Registered: October 2010
Junior Member
On Mon, Nov 01, 2010 at 08:59:13PM +0100, Jesper Juhl wrote:

> @@ -4169,13 +4169,11 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node)
> */
> if (!node_state(node, N_NORMAL_MEMORY))
> tmp = -1;
> - pn = kmalloc_node(sizeof(*pn), GFP_KERNEL, tmp);
> + pn = kmalloc_node(sizeof(*pn), GFP_KERNEL|__GFP_ZERO, tmp);

Use the simpler kzalloc_node()? It's introduced here:

commit 979b0fea2d9ae5d57237a368d571cbc84655fba6
Author: Jeff Layton <jlayton@redhat.com>
Date: Thu Jun 5 22:47:00 2008 -0700

vm: add kzalloc_node() inline


Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>

Thanks,
Fengguang
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containe rs
Previous Topic: Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.
Next Topic: Re: [PATCH] cgroup: Avoid a memset by using vzalloc
Goto Forum:
  


Current Time: Wed Mar 29 06:29:21 GMT 2023

Total time taken to generate the page: 0.00991 seconds