OpenVZ Forum


Home » Mailing lists » Devel » [PATCH -mmotm] res_counter: fix building failure
[PATCH -mmotm] res_counter: fix building failure [message #31505] Wed, 02 July 2008 06:16 Go to next message
Li Zefan is currently offline  Li Zefan
Messages: 90
Registered: February 2008
Member
From: openvz.org
kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'	

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---

should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch

--- linux-mm/kernel/res_counter.c.bak	2008-07-02 14:05:37.000000000 +0800
+++ linux-mm/kernel/res_counter.c	2008-07-02 14:07:36.000000000 +0800
@@ -13,6 +13,7 @@
 #include <linux/slab.h>
 #include <linux/res_counter.h>
 #include <linux/uaccess.h>
+#include <linux/mm.h>
 
 void res_counter_init(struct res_counter *counter)
 {
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Re: [PATCH -mmotm] res_counter: fix building failure [message #31506 is a reply to message #31505] Wed, 02 July 2008 06:45 Go to previous messageGo to next message
Paul Menage is currently offline  Paul Menage
Messages: 642
Registered: September 2006
Senior Member
From: openvz.org
On Tue, Jul 1, 2008 at 11:16 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
> kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
> kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>

Acked-by: Paul Menage <menage@google.com>

Thanks - what architecture did it break on?

Paul

> ---
>
> should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch
>
> --- linux-mm/kernel/res_counter.c.bak   2008-07-02 14:05:37.000000000 +0800
> +++ linux-mm/kernel/res_counter.c       2008-07-02 14:07:36.000000000 +0800
> @@ -13,6 +13,7 @@
>  #include <linux/slab.h>
>  #include <linux/res_counter.h>
>  #include <linux/uaccess.h>
> +#include <linux/mm.h>
>
>  void res_counter_init(struct res_counter *counter)
>  {
>
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Re: [PATCH -mmotm] res_counter: fix building failure [message #31507 is a reply to message #31506] Wed, 02 July 2008 06:49 Go to previous messageGo to next message
Li Zefan is currently offline  Li Zefan
Messages: 90
Registered: February 2008
Member
From: openvz.org
Paul Menage wrote:
> On Tue, Jul 1, 2008 at 11:16 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>> kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
>> kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'
>>
>> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> 
> Acked-by: Paul Menage <menage@google.com>
> 
> Thanks - what architecture did it break on?
> 

On my x86_32.

I guess this break has something to do with:

http://marc.info/?l=linux-mm&m=121389282702302&w=2
([PATCH -mm] PAGE_ALIGN(): correctly handle 64-bit values on 32-bit)

You tested the patch before that patch was accepted by Andrew.

> Paul
> 
>> ---
>>
>> should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch
>>
>> --- linux-mm/kernel/res_counter.c.bak   2008-07-02 14:05:37.000000000 +0800
>> +++ linux-mm/kernel/res_counter.c       2008-07-02 14:07:36.000000000 +0800
>> @@ -13,6 +13,7 @@
>>  #include <linux/slab.h>
>>  #include <linux/res_counter.h>
>>  #include <linux/uaccess.h>
>> +#include <linux/mm.h>
>>
>>  void res_counter_init(struct res_counter *counter)
>>  {
>>
> 
>
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Re: [PATCH -mmotm] res_counter: fix building failure [message #31535 is a reply to message #31507] Thu, 03 July 2008 09:09 Go to previous messageGo to next message
Balbir Singh is currently offline  Balbir Singh
Messages: 491
Registered: August 2006
Senior Member
From: openvz.org
Li Zefan wrote:
> Paul Menage wrote:
>> On Tue, Jul 1, 2008 at 11:16 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>>> kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
>>> kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'
>>>
>>> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
>> Acked-by: Paul Menage <menage@google.com>
>>
>> Thanks - what architecture did it break on?

Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>

CC'ing Andre as well


-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Re: [PATCH -mmotm] res_counter: fix building failure [message #31538 is a reply to message #31507] Thu, 03 July 2008 10:17 Go to previous message
Andrea Righi is currently offline  Andrea Righi
Messages: 65
Registered: May 2008
Member
From: openvz.org
Li Zefan wrote:
> Paul Menage wrote:
>> On Tue, Jul 1, 2008 at 11:16 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>>> kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
>>> kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'
>>>
>>> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
>> Acked-by: Paul Menage <menage@google.com>
>>
>> Thanks - what architecture did it break on?
>>
> 
> On my x86_32.
> 
> I guess this break has something to do with:
> 
> http://marc.info/?l=linux-mm&m=121389282702302&w=2
> ([PATCH -mm] PAGE_ALIGN(): correctly handle 64-bit values on 32-bit)

Exactly, your fix sounds good to me. Thanks.

-Andrea

> 
> You tested the patch before that patch was accepted by Andrew.
> 
>> Paul
>>
>>> ---
>>>
>>> should follow cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patch
>>>
>>> --- linux-mm/kernel/res_counter.c.bak   2008-07-02 14:05:37.000000000 +0800
>>> +++ linux-mm/kernel/res_counter.c       2008-07-02 14:07:36.000000000 +0800
>>> @@ -13,6 +13,7 @@
>>>  #include <linux/slab.h>
>>>  #include <linux/res_counter.h>
>>>  #include <linux/uaccess.h>
>>> +#include <linux/mm.h>
>>>
>>>  void res_counter_init(struct res_counter *counter)
>>>  {
>>>
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Previous Topic: AW: [Users] Multiple bridge support
Next Topic: Re: Attaching PID 0 to a cgroup
Goto Forum:
  


Current Time: Fri Sep 20 10:27:19 GMT 2019