OpenVZ Forum

Home » Mailing lists » Devel » Re: [PATCH] Fix and allocate less memory for ->priv'less netdevices
Re: [PATCH] Fix and allocate less memory for ->priv'less netdevices [message #29625] Fri, 18 April 2008 22:43
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: Alexey Dobriyan <>
Date: Fri, 18 Apr 2008 19:10:29 +0400

> This patch effectively reverts commit d0498d9ae1a5cebac363e38907266d5cd2eedf89
> aka "[NET]: Do not allocate unneeded memory for dev->priv alignment."
> It was found to be buggy because of final unconditional += NETDEV_ALIGN_CONST
> removal.
> For example, for sizeof(struct net_device) being 2048 bytes, "alloc_size"
> was also 2048 bytes, but allocator with debugging options turned on started
> giving out !32-byte aligned memory resulting in redzones overwrites.
> Patch does small optimization in ->priv'less case: bumping size to next
> 32-byte boundary was always done to ensure ->priv will also be aligned.
> But, no ->priv, no need to do that.
> Signed-off-by: Alexey Dobriyan <>

Thanks for finding and fixing this regression.

Patch applied.
Previous Topic: weekly report 14.04-18.04.2008
Next Topic: [RFC][-mm] Memory controller hierarchy support (v1)
Goto Forum:

Current Time: Tue May 30 18:34:24 GMT 2023

Total time taken to generate the page: 0.01274 seconds