OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 1/2 net-2.6.26] [NETNS]: Compilation fix for include/linux/netdevice.h.
[PATCH 1/2 net-2.6.26] [NETNS]: Compilation fix for include/linux/netdevice.h. [message #28657] Wed, 26 March 2008 07:40 Go to next message
den is currently offline  den
Messages: 494
Registered: December 2005
Senior Member
Commit commit c346dca10840a874240c78efe3f39acf4312a1f2
([NET] NETNS: Omit net_device->nd_net without CONFIG_NET_NS)
breaks compilation with CONFIG_NET_NS set.

Fix the typo.

Signed-off-by: Denis V. Lunev <den@openvz.org>
---
 include/linux/netdevice.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index d146be4..06ca84d 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -756,7 +756,7 @@ static inline
 void dev_net_set(struct net_device *dev, const struct net *net)
 {
 #ifdef CONFIG_NET_NS
-	dev->nd_dev = net;
+	dev->nd_net = net;
 #endif
 }
 
-- 
1.5.3.rc5
Re: [PATCH 1/2 net-2.6.26] [NETNS]: Compilation fix for include/linux/netdevice.h. [message #28661 is a reply to message #28657] Wed, 26 March 2008 07:47 Go to previous messageGo to next message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: "Denis V. Lunev" <den@openvz.org>
Date: Wed, 26 Mar 2008 10:40:58 +0300

> Commit commit c346dca10840a874240c78efe3f39acf4312a1f2
> ([NET] NETNS: Omit net_device->nd_net without CONFIG_NET_NS)
> breaks compilation with CONFIG_NET_NS set.
> 
> Fix the typo.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>

Applied.

Too bad allmodconfig doesn't enable things which are y/n only.
Re: [PATCH 1/2 net-2.6.26] [NETNS]: Compilation fix for include/linux/netdevice.h. [message #28663 is a reply to message #28661] Wed, 26 March 2008 07:52 Go to previous messageGo to next message
den is currently offline  den
Messages: 494
Registered: December 2005
Senior Member
On Wed, 2008-03-26 at 00:47 -0700, David Miller wrote:
> From: "Denis V. Lunev" <den@openvz.org>
> Date: Wed, 26 Mar 2008 10:40:58 +0300
> 
> > Commit commit c346dca10840a874240c78efe3f39acf4312a1f2
> > ([NET] NETNS: Omit net_device->nd_net without CONFIG_NET_NS)
> > breaks compilation with CONFIG_NET_NS set.
> > 
> > Fix the typo.
> > 
> > Signed-off-by: Denis V. Lunev <den@openvz.org>
> 
> Applied.
> 
> Too bad allmodconfig doesn't enable things which are y/n only.

We are in trouble for this right now :( there we do not work with SYSFS
enabled right now.
Re: [PATCH 1/2 net-2.6.26] [NETNS]: Compilation fix for include/linux/netdevice.h. [message #28666 is a reply to message #28661] Wed, 26 March 2008 08:05 Go to previous messageGo to next message
yoshfuji is currently offline  yoshfuji
Messages: 13
Registered: August 2007
Junior Member
In article <20080326.004742.92048899.davem@davemloft.net> (at Wed, 26 Mar 2008 00:47:42 -0700 (PDT)), David Miller <davem@davemloft.net> says:

> From: "Denis V. Lunev" <den@openvz.org>
> Date: Wed, 26 Mar 2008 10:40:58 +0300
> 
> > Commit commit c346dca10840a874240c78efe3f39acf4312a1f2
> > ([NET] NETNS: Omit net_device->nd_net without CONFIG_NET_NS)
> > breaks compilation with CONFIG_NET_NS set.
> > 
> > Fix the typo.
> > 
> > Signed-off-by: Denis V. Lunev <den@openvz.org>
> 
> Applied.
> 
> Too bad allmodconfig doesn't enable things which are y/n only.

Sorry for the typo.

Unfortunately, NET_NS depends on !SYSFS,
so allyesconfig might not help...

--yoshfuji
Re: [PATCH 1/2 net-2.6.26] [NETNS]: Compilation fix for include/linux/netdevice.h. [message #28669 is a reply to message #28666] Wed, 26 March 2008 08:51 Go to previous messageGo to next message
Daniel Lezcano is currently offline  Daniel Lezcano
Messages: 417
Registered: June 2006
Senior Member
YOSHIFUJI Hideaki / 吉藤英明 wrote:
> In article <20080326.004742.92048899.davem@davemloft.net> (at Wed, 26 Mar 2008 00:47:42 -0700 (PDT)), David Miller <davem@davemloft.net> says:
> 
>> From: "Denis V. Lunev" <den@openvz.org>
>> Date: Wed, 26 Mar 2008 10:40:58 +0300
>>
>>> Commit commit c346dca10840a874240c78efe3f39acf4312a1f2
>>> ([NET] NETNS: Omit net_device->nd_net without CONFIG_NET_NS)
>>> breaks compilation with CONFIG_NET_NS set.
>>>
>>> Fix the typo.
>>>
>>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> Applied.
>>
>> Too bad allmodconfig doesn't enable things which are y/n only.
> 
> Sorry for the typo.
> 
> Unfortunately, NET_NS depends on !SYSFS,
> so allyesconfig might not help...

Eric Biederman told us he has community acceptance for his approach and 
he will push sysfs per namespace in a few weeks.
Re: Re: [PATCH 1/2 net-2.6.26] [NETNS]: Compilation fix for include/linux/netdevice.h. [message #28680 is a reply to message #28661] Wed, 26 March 2008 09:22 Go to previous message
Alexey Dobriyan is currently offline  Alexey Dobriyan
Messages: 195
Registered: August 2006
Senior Member
On Wednesday 26 March 2008 10:47:42 David Miller wrote:
> From: "Denis V. Lunev" <den@openvz.org>
> Date: Wed, 26 Mar 2008 10:40:58 +0300
>
> > Commit commit c346dca10840a874240c78efe3f39acf4312a1f2
> > ([NET] NETNS: Omit net_device->nd_net without CONFIG_NET_NS)
> > breaks compilation with CONFIG_NET_NS set.
> >
> > Fix the typo.
> >
> > Signed-off-by: Denis V. Lunev <den@openvz.org>
>
> Applied.
>
> Too bad allmodconfig doesn't enable things which are y/n only.

Right now NET_NS can be more or less reliably selected via:

    echo '# CONFIG_SYSFS is not set' >foo
    echo 'CONFIG_NET_NS=y'           >>foo
    KCONFIG_ALLCONFIG=foo make allmodconfig

But this trick a) doesn't work with some options, b) likely to break when
someone will start selecting SYSFS.
Previous Topic: [PATCH][ICMP]: Dst entry leak in icmp_send host re-lookup code.
Next Topic: [PATCH 0/7][v2] Cloning PTS namespace
Goto Forum:
  


Current Time: Thu Jun 20 01:22:34 GMT 2024

Total time taken to generate the page: 0.03265 seconds