OpenVZ Forum


Home » Mailing lists » Devel » [PATCH net-2.6.25][NEIGH]: Add a comment describing what a NUD stands for.
[PATCH net-2.6.25][NEIGH]: Add a comment describing what a NUD stands for. [message #25905] Thu, 10 January 2008 15:05 Go to next message
Pavel Emelianov is currently offline  Pavel Emelianov
Messages: 1149
Registered: September 2006
Senior Member
When I studied the neighbor code I puzzled over what
the NUD can mean for quite a long time.

Finally I asked Alexey and he said that this was smth
like "neighbor unreachability detection".

Does it worth adding a comment helping future developers 
understand what's going on?

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

---

diff --git a/include/net/neighbour.h b/include/net/neighbour.h
index 09f9fc6..bc34144 100644
--- a/include/net/neighbour.h
+++ b/include/net/neighbour.h
@@ -26,6 +26,10 @@
 #include <linux/sysctl.h>
 #include <net/rtnetlink.h>
 
+/*
+ * NUD stands for "neighbor unreachability detection"
+ */
+
 #define NUD_IN_TIMER	(NUD_INCOMPLETE|NUD_REACHABLE|NUD_DELAY|NUD_PROBE)
 #define NUD_VALID	(NUD_PERMANENT|NUD_NOARP|NUD_REACHABLE|NUD_PROBE|NUD_STALE|NUD_DELAY)
 #define NUD_CONNECTED	(NUD_PERMANENT|NUD_NOARP|NUD_REACHABLE)
Re: [PATCH net-2.6.25][NEIGH]: Add a comment describing what a NUD stands for. [message #25918 is a reply to message #25905] Fri, 11 January 2008 06:37 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: Pavel Emelyanov <xemul@openvz.org>
Date: Thu, 10 Jan 2008 18:05:25 +0300

> When I studied the neighbor code I puzzled over what
> the NUD can mean for quite a long time.
> 
> Finally I asked Alexey and he said that this was smth
> like "neighbor unreachability detection".
> 
> Does it worth adding a comment helping future developers 
> understand what's going on?
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

NUD is a common acronym in the IPV6 RFCs and various books
on the topic, but it doesn't hurt to add this comment so I
applied this patch thanks.
Previous Topic: [PATCH net-2.6.25 0/6][NETNS]: Make ipv6_devconf (all and default) live in net namespaces
Next Topic: [PATCH -mm 1/4] genhd: fixup kobj_to_dev() macro
Goto Forum:
  


Current Time: Sun May 28 02:13:25 GMT 2023

Total time taken to generate the page: 0.01338 seconds