OpenVZ Forum


Home » Mailing lists » Devel » [PATCH -mm 2/4] hifn_795x: fixup container_of() usage
[PATCH -mm 2/4] hifn_795x: fixup container_of() usage [message #25721] Tue, 08 January 2008 08:44 Go to next message
Alexey Dobriyan is currently offline  Alexey Dobriyan
Messages: 195
Registered: August 2006
Senior Member
[PATCH -mm 2/4] hifn_795x: fixup container_of() usage

Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---

 drivers/crypto/hifn_795x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -664,7 +664,7 @@ struct hifn_context
 	atomic_t		sg_num;
 };
 
-#define crypto_alg_to_hifn(alg)	container_of(alg, struct hifn_crypto_alg, alg)
+#define crypto_alg_to_hifn(a)	container_of(a, struct hifn_crypto_alg, alg)
 
 static inline u32 hifn_read_0(struct hifn_device *dev, u32 reg)
 {
Re: [PATCH -mm 2/4] hifn_795x: fixup container_of() usage [message #25748 is a reply to message #25721] Tue, 08 January 2008 14:53 Go to previous messageGo to next message
Evgeniy Polyakov is currently offline  Evgeniy Polyakov
Messages: 11
Registered: November 2006
Junior Member
Hi.

On Tue, Jan 08, 2008 at 11:44:34AM +0300, Alexey Dobriyan (adobriyan@sw.ru) wrote:
> [PATCH -mm 2/4] hifn_795x: fixup container_of() usage
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>

Well, I have no problem with the patch, although do not see any gain
in it :)
I usually prefer to call members the same in container usage, since I
always forget where each one should be placed.

-- 
	Evgeniy Polyakov
Re: [PATCH -mm 2/4] hifn_795x: fixup container_of() usage [message #25777 is a reply to message #25721] Tue, 08 January 2008 20:46 Go to previous message
Herbert Xu is currently offline  Herbert Xu
Messages: 45
Registered: April 2007
Member
On Tue, Jan 08, 2008 at 11:44:34AM +0300, Alexey Dobriyan wrote:
> [PATCH -mm 2/4] hifn_795x: fixup container_of() usage
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>

Patch applied.  Thanks.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Previous Topic: util-linux-ng: unprivileged mounts support
Next Topic: [PATCH net-2.6.25 0/6] Use ctl paths in the networking code.
Goto Forum:
  


Current Time: Mon Jun 17 01:56:25 GMT 2024

Total time taken to generate the page: 0.04016 seconds