OpenVZ Forum


Home » Mailing lists » Devel » [patch 1/1][NETNS] fix fib_frontend compilation error
[patch 1/1][NETNS] fix fib_frontend compilation error [message #23232] Wed, 14 November 2007 14:24 Go to next message
Daniel Lezcano is currently offline  Daniel Lezcano
Messages: 417
Registered: June 2006
Senior Member
Added net namespace parameter to fib4_rules_init when statically
defined in fib_frontend.c

Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
---
 net/ipv4/fib_frontend.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6-netns/net/ipv4/fib_frontend.c
===================================================================
--- linux-2.6-netns.orig/net/ipv4/fib_frontend.c
+++ linux-2.6-netns/net/ipv4/fib_frontend.c
@@ -59,7 +59,7 @@ struct fib_table *ip_fib_main_table;
 #define FIB_TABLE_HASHSZ 1
 static struct hlist_head fib_table_hash[FIB_TABLE_HASHSZ];
 
-static void __init fib4_rules_init(void)
+static void __init fib4_rules_init(struct net *net)
 {
 	ip_fib_local_table = fib_hash_init(RT_TABLE_LOCAL);
 	hlist_add_head_rcu(&ip_fib_local_table->tb_hlist, &fib_table_hash[0]);

-- 
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Re: [patch 1/1][NETNS] fix fib_frontend compilation error [message #23241 is a reply to message #23232] Wed, 14 November 2007 16:14 Go to previous messageGo to next message
den is currently offline  den
Messages: 494
Registered: December 2005
Senior Member
applied... though I am not too familiar with git and the author has been
set to me rather than you with your signed-off :(

Sorry,
	Den

dlezcano@fr.ibm.com wrote:
> Added net namespace parameter to fib4_rules_init when statically
> defined in fib_frontend.c
> 
> Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
> ---
>  net/ipv4/fib_frontend.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6-netns/net/ipv4/fib_frontend.c
> ===================================================================
> --- linux-2.6-netns.orig/net/ipv4/fib_frontend.c
> +++ linux-2.6-netns/net/ipv4/fib_frontend.c
> @@ -59,7 +59,7 @@ struct fib_table *ip_fib_main_table;
>  #define FIB_TABLE_HASHSZ 1
>  static struct hlist_head fib_table_hash[FIB_TABLE_HASHSZ];
>  
> -static void __init fib4_rules_init(void)
> +static void __init fib4_rules_init(struct net *net)
>  {
>  	ip_fib_local_table = fib_hash_init(RT_TABLE_LOCAL);
>  	hlist_add_head_rcu(&ip_fib_local_table->tb_hlist, &fib_table_hash[0]);
> 

_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Re: [patch 1/1][NETNS] fix fib_frontend compilation error [message #23242 is a reply to message #23241] Wed, 14 November 2007 16:18 Go to previous messageGo to next message
Daniel Lezcano is currently offline  Daniel Lezcano
Messages: 417
Registered: June 2006
Senior Member
Denis V. Lunev wrote:
> applied... though I am not too familiar with git and the author has been
> set to me rather than you with your signed-off :(

It's ok :)

I think you should specify the --author option when commiting.

By the way, I see that there are some patches without your Signed-off 
and you are in the delivery path, shouldn't you Signed-off all the patches ?
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Re: [patch 1/1][NETNS] fix fib_frontend compilation error [message #23314 is a reply to message #23242] Thu, 15 November 2007 13:31 Go to previous messageGo to next message
ebiederm is currently offline  ebiederm
Messages: 1354
Registered: February 2006
Senior Member
Daniel Lezcano <dlezcano@fr.ibm.com> writes:

> Denis V. Lunev wrote:
>> applied... though I am not too familiar with git and the author has been
>> set to me rather than you with your signed-off :(
>
> It's ok :)
>
> I think you should specify the --author option when commiting.

My normal technique here is to simply save the entire email message
and then do git-am email.txt and git picks it all up from the
headers.

Eric

_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Re: [patch 1/1][NETNS] fix fib_frontend compilation error [message #23406 is a reply to message #23232] Fri, 16 November 2007 11:33 Go to previous message
den is currently offline  den
Messages: 494
Registered: December 2005
Senior Member
apparently, the patch is not enough, fib4_rules_init is called from
non-init function. I'll drop this one during port to 2.6.25 tree

dlezcano@fr.ibm.com wrote:
> Added net namespace parameter to fib4_rules_init when statically
> defined in fib_frontend.c
> 
> Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
> ---
>  net/ipv4/fib_frontend.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6-netns/net/ipv4/fib_frontend.c
> ===================================================================
> --- linux-2.6-netns.orig/net/ipv4/fib_frontend.c
> +++ linux-2.6-netns/net/ipv4/fib_frontend.c
> @@ -59,7 +59,7 @@ struct fib_table *ip_fib_main_table;
>  #define FIB_TABLE_HASHSZ 1
>  static struct hlist_head fib_table_hash[FIB_TABLE_HASHSZ];
>  
> -static void __init fib4_rules_init(void)
> +static void __init fib4_rules_init(struct net *net)
>  {
>  	ip_fib_local_table = fib_hash_init(RT_TABLE_LOCAL);
>  	hlist_add_head_rcu(&ip_fib_local_table->tb_hlist, &fib_table_hash[0]);
> 

_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Previous Topic: [PATCH 2/2] move unneeded data to initdata section
Next Topic: [PATCH 6/6 net-2.6.25][RAW] Consolidate proc interface
Goto Forum:
  


Current Time: Tue Jul 16 12:45:32 GMT 2024

Total time taken to generate the page: 0.02881 seconds