OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] No need to inc/dec packet_socks_nr if PACKET_REFCNT_DEBUG is not set
[PATCH] No need to inc/dec packet_socks_nr if PACKET_REFCNT_DEBUG is not set [message #22954] Thu, 08 November 2007 10:34 Go to next message
den is currently offline  den
Messages: 494
Registered: December 2005
Senior Member
No need to inc/dec packet_socks_nr if PACKET_REFCNT_DEBUG is not set.

Signed-off-by: Denis V. Lunev <den@openvz.org>

--- ./net/packet/af_packet.c.packetrefcnt	2007-11-08 13:48:22.000000000 +0300
+++ ./net/packet/af_packet.c	2007-11-08 13:54:29.000000000 +0300
@@ -135,7 +135,9 @@ dev->hard_header == NULL (ll header is a
    packet classifier depends on it.
  */
 
+#ifdef PACKET_REFCNT_DEBUG
 static atomic_t packet_socks_nr;
+#endif
 
 
 /* Private packet socket structures. */
@@ -232,8 +234,8 @@ static void packet_sock_destruct(struct 
 		return;
 	}
 
-	atomic_dec(&packet_socks_nr);
 #ifdef PACKET_REFCNT_DEBUG
+	atomic_dec(&packet_socks_nr);
 	printk(KERN_DEBUG "PACKET socket %p is free, %d are alive\n", sk, atomic_read(&packet_socks_nr));
 #endif
 }
@@ -1005,7 +1007,9 @@ static int packet_create(struct net *net
 	po->num = proto;
 
 	sk->sk_destruct = packet_sock_destruct;
+#ifdef PACKET_REFCNT_DEBUG
 	atomic_inc(&packet_socks_nr);
+#endif
 
 	/*
 	 *	Attach a protocol block
Re: [PATCH] No need to inc/dec packet_socks_nr if PACKET_REFCNT_DEBUG is not set [message #22956 is a reply to message #22954] Thu, 08 November 2007 10:48 Go to previous message
den is currently offline  den
Messages: 494
Registered: December 2005
Senior Member
pls disregard this, Pavel have sent one similar already

Denis V. Lunev wrote:
> No need to inc/dec packet_socks_nr if PACKET_REFCNT_DEBUG is not set.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> 
> --- ./net/packet/af_packet.c.packetrefcnt	2007-11-08 13:48:22.000000000 +0300
> +++ ./net/packet/af_packet.c	2007-11-08 13:54:29.000000000 +0300
> @@ -135,7 +135,9 @@ dev->hard_header == NULL (ll header is a
>     packet classifier depends on it.
>   */
>  
> +#ifdef PACKET_REFCNT_DEBUG
>  static atomic_t packet_socks_nr;
> +#endif
>  
>  
>  /* Private packet socket structures. */
> @@ -232,8 +234,8 @@ static void packet_sock_destruct(struct 
>  		return;
>  	}
>  
> -	atomic_dec(&packet_socks_nr);
>  #ifdef PACKET_REFCNT_DEBUG
> +	atomic_dec(&packet_socks_nr);
>  	printk(KERN_DEBUG "PACKET socket %p is free, %d are alive\n", sk, atomic_read(&packet_socks_nr));
>  #endif
>  }
> @@ -1005,7 +1007,9 @@ static int packet_create(struct net *net
>  	po->num = proto;
>  
>  	sk->sk_destruct = packet_sock_destruct;
> +#ifdef PACKET_REFCNT_DEBUG
>  	atomic_inc(&packet_socks_nr);
> +#endif
>  
>  	/*
>  	 *	Attach a protocol block
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Previous Topic: [PATCH][PACKET] Remove unneeded packet_socks_nr variable
Next Topic: [PATCH] [NETFILTER] Consolidate nf_sockopt and compat_nf_sockopt v2
Goto Forum:
  


Current Time: Sun Jul 14 20:58:57 GMT 2024

Total time taken to generate the page: 0.02364 seconds