OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 2/3] Remove in-code externs for some functions from net/core/dev.c
[PATCH 2/3] Remove in-code externs for some functions from net/core/dev.c [message #22155] Mon, 22 October 2007 15:25 Go to next message
Pavel Emelianov is currently offline  Pavel Emelianov
Messages: 1149
Registered: September 2006
Senior Member
Inconsistent prototype and real type for functions may have
worse consequences, than those for variables, so move them
into a header.

Since they are used privately in net/core, make this file
reside in the same place.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

---

diff --git a/net/core/dev.c b/net/core/dev.c
index 8726589..9ea3665 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -120,6 +120,8 @@
 #include <linux/ctype.h>
 #include <linux/if_arp.h>
 
+#include "net-sysfs.h"
+
 /*
  *	The list of packet types we will receive (as opposed to discard)
  *	and the routines to invoke.
@@ -249,10 +251,6 @@ static RAW_NOTIFIER_HEAD(netdev_chain);
 
 DEFINE_PER_CPU(struct softnet_data, softnet_data);
 
-extern int netdev_kobject_init(void);
-extern int netdev_register_kobject(struct net_device *);
-extern void netdev_unregister_kobject(struct net_device *);
-
 #ifdef CONFIG_DEBUG_LOCK_ALLOC
 /*
  * register_netdevice() inits dev->_xmit_lock and sets lockdep class
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 6628e45..61ead1d 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -18,6 +18,8 @@
 #include <linux/wireless.h>
 #include <net/iw_handler.h>
 
+#include "net-sysfs.h"
+
 #ifdef CONFIG_SYSFS
 static const char fmt_hex[] = "%#x\n";
 static const char fmt_long_hex[] = "%#lx\n";
diff --git a/net/core/net-sysfs.h b/net/core/net-sysfs.h
new file mode 100644
index 0000000..a41683d
--- /dev/null
+++ b/net/core/net-sysfs.h
@@ -0,0 +1,8 @@
+#ifndef __NET_SYSFS_H__
+#define __NET_SYSFS_H__
+
+int netdev_kobject_init(void);
+int netdev_register_kobject(struct net_device *);
+void netdev_unregister_kobject(struct net_device *);
+
+#endif
-- 
1.5.3.4
Re: [PATCH 2/3] Remove in-code externs for some functions from net/core/dev.c [message #22241 is a reply to message #22155] Wed, 24 October 2007 04:14 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: Pavel Emelyanov <xemul@openvz.org>
Date: Mon, 22 Oct 2007 19:25:50 +0400

> Inconsistent prototype and real type for functions may have
> worse consequences, than those for variables, so move them
> into a header.
> 
> Since they are used privately in net/core, make this file
> reside in the same place.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

Applied, thanks.
Previous Topic: [PATCH 1/3] Don't declare extern variables in net/core/sysctl_net_core.c
Next Topic: [PATCH 3/3] Use BUILD_BUG_ON in net/core/flowi.c
Goto Forum:
  


Current Time: Sat May 25 01:18:38 GMT 2024

Total time taken to generate the page: 0.01687 seconds