OpenVZ Forum


Home » Mailing lists » Devel » [PATCH][NETNS] Don't panic on creating the namespace's loopback
[PATCH][NETNS] Don't panic on creating the namespace's loopback [message #21719] Mon, 15 October 2007 10:23 Go to next message
Pavel Emelianov is currently offline  Pavel Emelianov
Messages: 1149
Registered: September 2006
Senior Member
When the loopback device is failed to initialize inside the new 
namespaces, panic() is called. Do not do it when the namespace 
in question is not the init_net.

Plus cleanup the error path a bit.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

---

 drivers/net/loopback.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
index be25aa3..662b8d1 100644
--- a/drivers/net/loopback.c
+++ b/drivers/net/loopback.c
@@ -265,17 +265,16 @@ static __net_init int loopback_net_init(struct net *net)
 	if (err)
 		goto out_free_netdev;
 
-	err = 0;
 	net->loopback_dev = dev;
+	return 0;
 
-out:
-	if (err)
-		panic("loopback: Failed to register netdevice: %d\n", err);
-	return err;
 
 out_free_netdev:
 	free_netdev(dev);
-	goto out;
+out:
+	if (net == &init_net)
+		panic("loopback: Failed to register netdevice: %d\n", err);
+	return err;
 }
 
 static __net_exit void loopback_net_exit(struct net *net)
Re: [PATCH][NETNS] Don't panic on creating the namespace's loopback [message #21746 is a reply to message #21719] Mon, 15 October 2007 19:55 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: Pavel Emelyanov <xemul@openvz.org>
Date: Mon, 15 Oct 2007 14:23:13 +0400

> When the loopback device is failed to initialize inside the new 
> namespaces, panic() is called. Do not do it when the namespace 
> in question is not the init_net.
> 
> Plus cleanup the error path a bit.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

Fair enough, applied.
Previous Topic: [PATCH] Ensure that pneigh_lookup is protected with RTNL
Next Topic: [PATCH] Consolidate the ip6_pol_route_(input|output) pair
Goto Forum:
  


Current Time: Thu Jun 01 15:01:55 GMT 2023

Total time taken to generate the page: 0.01381 seconds