OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] [IPV6]: dst_entry leak in ip4ip6_err.
[PATCH] [IPV6]: dst_entry leak in ip4ip6_err. [message #27090] Fri, 08 February 2008 17:00
den is currently offline  den
Messages: 494
Registered: December 2005
Senior Member
The result of the ip_route_output is not assigned to skb. This means that
- it is leaked
- possible OOPS below dereferrencing skb->dst
- no ICMP message for this case

Signed-off-by: Denis V. Lunev <den@openvz.org>
---
 net/ipv6/ip6_tunnel.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
index 9031e52..cd94064 100644
--- a/net/ipv6/ip6_tunnel.c
+++ b/net/ipv6/ip6_tunnel.c
@@ -550,6 +550,7 @@ ip4ip6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
 			ip_rt_put(rt);
 			goto out;
 		}
+		skb2->dst = (struct dst_entry *)rt;
 	} else {
 		ip_rt_put(rt);
 		if (ip_route_input(skb2, eiph->daddr, eiph->saddr, eiph->tos,
-- 
1.5.3.rc5
 
Read Message
Previous Topic: [PATCH] Filesystems visibility control group
Next Topic: OT: Text/filesystem intefaces to netfilter
Goto Forum:
  


Current Time: Thu Aug 21 19:17:24 GMT 2025

Total time taken to generate the page: 0.08792 seconds