OpenVZ Forum


Home » Mailing lists » Devel » [PATCH][NET-2.6.24] Remove double dev->flags checking when calling dev_close()
[PATCH][NET-2.6.24] Remove double dev->flags checking when calling dev_close() [message #21452] Tue, 09 October 2007 10:50 Go to previous message
Pavel Emelianov is currently offline  Pavel Emelianov
Messages: 1149
Registered: September 2006
Senior Member
The unregister_netdevice() and dev_change_net_namespace() 
both check for dev->flags to be IFF_UP before calling the 
dev_close(), but the dev_close() checks for IFF_UP itself, 
so remove those unneeded checks.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

---

diff --git a/net/core/dev.c b/net/core/dev.c
index e7e728a..1e169a5 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3893,8 +3893,7 @@ void unregister_netdevice(struct net_dev
 	BUG_ON(dev->reg_state != NETREG_REGISTERED);
 
 	/* If device is running, close it first. */
-	if (dev->flags & IFF_UP)
-		dev_close(dev);
+	dev_close(dev);
 
 	/* And unlink it from device chain. */
 	unlist_netdevice(dev);
@@ -4018,8 +4017,7 @@ int dev_change_net_namespace(struct net_
 	 */
 
 	/* If device is running close it first. */
-	if (dev->flags & IFF_UP)
-		dev_close(dev);
+	dev_close(dev);
 
 	/* And unlink it from device chain */
 	err = -ENODEV;
 
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH 0/6][NET-2.6.24] Consolidate private allocations in seq files
Next Topic: [PATCH] Rewrite proc seq operations via seq_list_xxx ones
Goto Forum:
  


Current Time: Mon Aug 04 20:36:13 GMT 2025

Total time taken to generate the page: 0.98496 seconds