OpenVZ Forum: Devel » [PATCH] Fix leaks on /proc/{*/sched, sched_debug, timer_list, timer

Home » Mailing lists » Devel » [PATCH] Fix leaks on /proc/{*/sched, sched_debug, timer_list, timer_stats}

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[PATCH] Fix leaks on /proc/{*/sched, sched_debug, timer_list, timer_stats} [message #15036]

Tue, 17 July 2007 12:25

Alexey Dobriyan
Messages: 195
Registered: August 2006

Senior Member

On every open/close one struct seq_operations leaks.
Kudos to /proc/slab_allocators.

Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---

fs/proc/base.c | 2 +-
kernel/sched_debug.c | 2 +-
kernel/time/timer_list.c | 2 +-
kernel/time/timer_stats.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -926,7 +926,7 @@ static const struct file_operations proc_pid_sched_operations = {
.read = seq_read,
.write = sched_write,
.llseek = seq_lseek,
- .release = seq_release,
+ .release = single_release,
};

#endif
--- a/kernel/sched_debug.c
+++ b/kernel/sched_debug.c
@@ -200,7 +200,7 @@ static struct file_operations sched_debug_fops = {
.open = sched_debug_open,
.read = seq_read,
.llseek = seq_lseek,
- .release = seq_release,
+ .release = single_release,
};

static int __init init_sched_debug_procfs(void)
--- a/kernel/time/timer_list.c
+++ b/kernel/time/timer_list.c
@@ -267,7 +267,7 @@ static struct file_operations timer_list_fops = {
.open = timer_list_open,
.read = seq_read,
.llseek = seq_lseek,
- .release = seq_release,
+ .release = single_release,
};

static int __init init_timer_list_procfs(void)
--- a/kernel/time/timer_stats.c
+++ b/kernel/time/timer_stats.c
@@ -399,7 +399,7 @@ static struct file_operations tstats_fops = {
.read = seq_read,
.write = tstats_write,
.llseek = seq_lseek,
- .release = seq_release,
+ .release = single_release,
};

void __init init_timer_stats(void)

Report message to a moderator

[Message index]

		[PATCH] Fix leaks on /proc/{*/sched, sched_debug, timer_list, timer_stats} By: Alexey Dobriyan on Tue, 17 July 2007 12:25
		Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats} By: Ingo Molnar on Tue, 17 July 2007 12:36
		[PATCH] Fix leak on /proc/lockdep_stats By: Alexey Dobriyan on Tue, 17 July 2007 12:57
		Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats} By: Andrew Morton on Wed, 18 July 2007 00:53
		Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats} By: Chris Wright on Wed, 18 July 2007 01:28

Previous Topic:	[PATCH 1/1] user namespace: fix copy_user_ns return value
Next Topic:	user namespace - introduction

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Aug 07 23:23:05 GMT 2024

Total time taken to generate the page: 0.02738 seconds