OpenVZ Forum: Devel » [PATCH] i2c-ixp4xx: fix ") != 0))" typo

Home » Mailing lists » Devel » [PATCH] i2c-ixp4xx: fix ") != 0))" typo

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[PATCH] i2c-ixp4xx: fix ") != 0))" typo [message #8324]

Wed, 15 November 2006 13:45

Alexey Dobriyan
Messages: 195
Registered: August 2006

Senior Member

i2c_bit_add_bus() returns -E;
-E != 0 => err = 1
probe fails with positive error code

Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>
---

drivers/i2c/busses/i2c-ixp4xx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/i2c/busses/i2c-ixp4xx.c
+++ b/drivers/i2c/busses/i2c-ixp4xx.c
@@ -137,7 +137,8 @@ static int ixp4xx_i2c_probe(struct platf
gpio_line_set(gpio->scl_pin, 0);
gpio_line_set(gpio->sda_pin, 0);

- if ((err = i2c_bit_add_bus(&drv_data->adapter) != 0)) {
+ err = i2c_bit_add_bus(&drv_data->adapter);
+ if (err != 0)
printk(KERN_ERR "ERROR: Could not install %s\n", plat_dev->dev.bus_id);

kfree(drv_data);

Report message to a moderator