OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] SUNRPC: destroy freshly allocated transport in case of sockaddr init error
[PATCH] SUNRPC: destroy freshly allocated transport in case of sockaddr init error [message #44039] Thu, 10 November 2011 10:36
Stanislav Kinsbursky is currently offline  Stanislav Kinsbursky
Messages: 683
Registered: October 2011
Senior Member
Otherwise we will leak xprt structure and struct net reference.

Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>

---
net/sunrpc/xprtsock.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index d7f97ef..2d78d95 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -2530,8 +2530,10 @@ static struct rpc_xprt *xs_setup_xprt(struct xprt_create *args,
int err;
err = xs_init_anyaddr(args->dstaddr->sa_family,
(struct sockaddr *)&new->srcaddr);
- if (err != 0)
+ if (err != 0) {
+ xprt_free(xprt);
return ERR_PTR(err);
+ }
}

return xprt;
 
Read Message
Previous Topic: Re: [PATCH 2/7] event: don't divide events if it has field period
Next Topic: [PATCH] sched: don't call task_group() many times in set_task_rq()
Goto Forum:
  


Current Time: Fri Aug 22 12:44:19 GMT 2025

Total time taken to generate the page: 0.05904 seconds