OpenVZ Forum


Home » Mailing lists » Devel » [patch 07/22] ext4: remove extra IS_RDONLY() check
[patch 07/22] ext4: remove extra IS_RDONLY() check [message #18807] Thu, 07 June 2007 15:25
Cedric Le Goater is currently offline  Cedric Le Goater
Messages: 443
Registered: February 2006
Senior Member
From: Dave Hansen <hansendc@us.ibm.com>

ext4_change_inode_journal_flag() is only called from one
location: ext4_ioctl(EXT3_IOC_SETFLAGS).  That ioctl
case already has a IS_RDONLY() call in it so this one
is superfluous.

Signed-off-by: Dave Hansen <hansendc@us.ibm.com>
---

---
 fs/ext4/inode.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: 2.6.22-rc4-mm2-robindmount/fs/ext4/inode.c
===================================================================
--- 2.6.22-rc4-mm2-robindmount.orig/fs/ext4/inode.c
+++ 2.6.22-rc4-mm2-robindmount/fs/ext4/inode.c
@@ -3359,7 +3359,7 @@ int ext4_change_inode_journal_flag(struc
 	 */
 
 	journal = EXT4_JOURNAL(inode);
-	if (is_journal_aborted(journal) || IS_RDONLY(inode))
+	if (is_journal_aborted(journal))
 		return -EROFS;
 
 	jbd2_journal_lock_updates(journal);

-- 
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
Previous Topic: [patch 06/22] ext3: remove extra IS_RDONLY() check
Next Topic: [patch 08/22] r/o bind mounts: elevate write count for some ioctls
Goto Forum:
  


Current Time: Thu Aug 21 18:16:59 GMT 2025

Total time taken to generate the page: 0.06551 seconds