OpenVZ Forum


Home » Mailing lists » Devel » [RFC][PATCH] Remove copy_pid_ns()
[RFC][PATCH] Remove copy_pid_ns() [message #17663] Sat, 10 March 2007 04:03 Go to next message
Sukadev Bhattiprolu is currently offline  Sukadev Bhattiprolu
Messages: 413
Registered: August 2006
Senior Member
From: Sukadev Bhattiprolu <sukadev@us.ibm.com>
Subject: [RFC][PATCH]

Remove copy_pid_ns() as its no longer needed.

Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>
Cc: Cedric Le Goater <clg@fr.ibm.com>
Cc: Dave Hansen <haveblue@us.ibm.com>
Cc: Serge Hallyn <serue@us.ibm.com>
Cc: containers@lists.osdl.org
---
 include/linux/pid_namespace.h |    1 -
 kernel/pid.c                  |   12 ------------
 2 files changed, 13 deletions(-)

Index: lx26-20-mm2b/include/linux/pid_namespace.h
===================================================================
--- lx26-20-mm2b.orig/include/linux/pid_namespace.h	2007-03-09 19:01:09.000000000 -0800
+++ lx26-20-mm2b/include/linux/pid_namespace.h	2007-03-09 19:02:05.000000000 -0800
@@ -31,7 +31,6 @@ static inline void get_pid_ns(struct pid
 
 extern int unshare_pid_ns(unsigned long unshare_ns_flags,
 			struct pid_nr **new_pid_nr);
-extern int copy_pid_ns(int flags, struct task_struct *tsk);
 extern void free_pid_ns(struct kref *kref);
 extern struct pid_namespace *pid_ns(struct pid * pid);
 
Index: lx26-20-mm2b/kernel/pid.c
===================================================================
--- lx26-20-mm2b.orig/kernel/pid.c	2007-03-09 19:01:09.000000000 -0800
+++ lx26-20-mm2b/kernel/pid.c	2007-03-09 19:02:05.000000000 -0800
@@ -579,18 +579,6 @@ int unshare_pid_ns(unsigned long unshare
 	return 0;
 }
 
-int copy_pid_ns(int flags, struct task_struct *tsk)
-{
-	struct pid_namespace *old_ns = task_pid_ns(tsk);
-	int err = 0;
-
-	if (!old_ns)
-		return 0;
-
-	get_pid_ns(old_ns);
-	return err;
-}
-
 void free_pid_ns(struct kref *kref)
 {
 	struct pid_namespace *ns;
_______________________________________________
Containers mailing list
Containers@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/containers
Re: [RFC][PATCH 5/5] Remove copy_pid_ns() [message #17664 is a reply to message #17663] Sat, 10 March 2007 04:08 Go to previous message
Sukadev Bhattiprolu is currently offline  Sukadev Bhattiprolu
Messages: 413
Registered: August 2006
Senior Member
This is actually PATCH 5/5.

sukadev@us.ibm.com [sukadev@us.ibm.com] wrote:
| 
| From: Sukadev Bhattiprolu <sukadev@us.ibm.com>
| Subject: [RFC][PATCH 5/5] Remove copy_pid_ns()
| 
| Remove copy_pid_ns() as its no longer needed.
| 
| Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>
| Cc: Cedric Le Goater <clg@fr.ibm.com>
| Cc: Dave Hansen <haveblue@us.ibm.com>
| Cc: Serge Hallyn <serue@us.ibm.com>
| Cc: containers@lists.osdl.org
| ---
|  include/linux/pid_namespace.h |    1 -
|  kernel/pid.c                  |   12 ------------
|  2 files changed, 13 deletions(-)
| 
| Index: lx26-20-mm2b/include/linux/pid_namespace.h
| ===================================================================
| --- lx26-20-mm2b.orig/include/linux/pid_namespace.h	2007-03-09 19:01:09.000000000 -0800
| +++ lx26-20-mm2b/include/linux/pid_namespace.h	2007-03-09 19:02:05.000000000 -0800
| @@ -31,7 +31,6 @@ static inline void get_pid_ns(struct pid
|  
|  extern int unshare_pid_ns(unsigned long unshare_ns_flags,
|  			struct pid_nr **new_pid_nr);
| -extern int copy_pid_ns(int flags, struct task_struct *tsk);
|  extern void free_pid_ns(struct kref *kref);
|  extern struct pid_namespace *pid_ns(struct pid * pid);
|  
| Index: lx26-20-mm2b/kernel/pid.c
| ===================================================================
| --- lx26-20-mm2b.orig/kernel/pid.c	2007-03-09 19:01:09.000000000 -0800
| +++ lx26-20-mm2b/kernel/pid.c	2007-03-09 19:02:05.000000000 -0800
| @@ -579,18 +579,6 @@ int unshare_pid_ns(unsigned long unshare
|  	return 0;
|  }
|  
| -int copy_pid_ns(int flags, struct task_struct *tsk)
| -{
| -	struct pid_namespace *old_ns = task_pid_ns(tsk);
| -	int err = 0;
| -
| -	if (!old_ns)
| -		return 0;
| -
| -	get_pid_ns(old_ns);
| -	return err;
| -}
| -
|  void free_pid_ns(struct kref *kref)
|  {
|  	struct pid_namespace *ns;
| _______________________________________________
| Containers mailing list
| Containers@lists.osdl.org
| https://lists.osdl.org/mailman/listinfo/containers
_______________________________________________
Containers mailing list
Containers@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/containers
Previous Topic: [RFC][PATCH 4/5] Remove nsproxy->pid_ns
Next Topic: [RFC][PATCH 0/6] Allow unsharing pid namespace
Goto Forum:
  


Current Time: Tue Oct 14 07:46:59 GMT 2025

Total time taken to generate the page: 0.33566 seconds