Home » Mailing lists » Devel » [PATCH] More vzdquota debugging for #341, #116, #177
| [PATCH] More vzdquota debugging for #341, #116, #177 [message #8284] |
Mon, 13 November 2006 16:22 |
Alexey Dobriyan
Messages: 195
Registered: August 2006
|
Senior Member |
|
|
* Extend ->origin into array for previous origin tracking.
* Print last two origins in debugging message.
* Also print i_mode, i_op, i_fop, ... of the offending inode.
diff --git a/fs/vzdquot.c b/fs/vzdquot.c
index e723ec7..c5148b8 100644
--- a/fs/vzdquot.c
+++ b/fs/vzdquot.c
@@ -549,10 +549,17 @@ static inline int vzquota_qlnk_is_empty(
return qlnk->qmblk == __VZ_QUOTA_EMPTY;
}
+static inline void set_qlnk_origin(struct vz_quota_ilink *qlnk,
+ unsigned char origin)
+{
+ qlnk->origin[0] = qlnk->origin[1];
+ qlnk->origin[1] = origin;
+}
+
static inline void vzquota_qlnk_set_empty(struct vz_quota_ilink *qlnk)
{
qlnk->qmblk = __VZ_QUOTA_EMPTY;
- qlnk->origin = VZ_QUOTAO_SETE;
+ set_qlnk_origin(qlnk, VZ_QUOTAO_SETE);
}
void vzquota_qlnk_init(struct vz_quota_ilink *qlnk)
@@ -560,7 +567,7 @@ void vzquota_qlnk_init(struct vz_quota_i
memset(qlnk, 0, sizeof(*qlnk));
INIT_LIST_HEAD(&qlnk->list);
vzquota_qlnk_set_empty(qlnk);
- qlnk->origin = VZ_QUOTAO_INIT;
+ set_qlnk_origin(qlnk, VZ_QUOTAO_INIT);
}
void vzquota_qlnk_destroy(struct vz_quota_ilink *qlnk)
@@ -587,7 +594,7 @@ #if defined(CONFIG_VZ_QUOTA_UGID)
#endif
if (qlnk->qmblk != NULL && qlnk->qmblk != VZ_QUOTA_BAD)
qmblk_put(qlnk->qmblk);
- qlnk->origin = VZ_QUOTAO_DESTR;
+ set_qlnk_origin(qlnk, VZ_QUOTAO_DESTR);
}
/**
@@ -613,7 +620,7 @@ static void vzquota_qlnk_swap(struct vz_
if (qb != __VZ_QUOTA_EMPTY && qb != VZ_QUOTA_BAD)
list_add(&qli->list, &qb->dq_ilink_list);
INIT_LIST_HEAD(&qlt->list);
- qli->origin = VZ_QUOTAO_SWAP;
+ set_qlnk_origin(qli, VZ_QUOTAO_SWAP);
for (i = 0; i < MAXQUOTAS; i++) {
qu = qlt->qugid[i];
@@ -774,7 +781,7 @@ static void __vzquota_inode_init(struct
vzquota_qlnk_init(INODE_QLNK(inode));
inode->i_dquot[USRQUOTA] = (void *)~(unsigned long)NODQUOT;
}
- INODE_QLNK(inode)->origin = origin;
+ set_qlnk_origin(INODE_QLNK(inode), origin);
}
/**
@@ -789,7 +796,7 @@ static void vzquota_inode_drop(struct in
vzquota_qlnk_init(&qlnk);
inode_qmblk_lock(inode->i_sb);
vzquota_qlnk_swap(&qlnk, INODE_QLNK(inode));
- INODE_QLNK(inode)->origin = VZ_QUOTAO_DRCAL;
+ set_qlnk_origin(INODE_QLNK(inode), VZ_QUOTAO_DRCAL);
inode->i_dquot[USRQUOTA] = NODQUOT;
inode_qmblk_unlock(inode->i_sb);
vzquota_qlnk_destroy(&qlnk);
@@ -816,9 +823,10 @@ static int vzquota_inode_qmblk_set(struc
struct vz_quota_ilink *qlnk)
{
if (qmblk == NULL) {
- printk(KERN_ERR "VZDQ: NULL in set, "
- "orig %u, dev %s, inode %lu, fs %s\n",
- INODE_QLNK(inode)->origin,
+ printk(KERN_ERR "VZDQ: NULL in set, orig {%u, %u}, "
+ "dev %s, inode %lu, fs %s\n",
+ INODE_QLNK(inode)->origin[0],
+ INODE_QLNK(inode)->origin[1],
inode->i_sb->s_id, inode->i_ino,
inode->i_sb->s_type->name);
printk(KERN_ERR "current %d (%s), VE %d\n",
@@ -837,7 +845,7 @@ static int vzquota_inode_qmblk_set(struc
return 1;
}
vzquota_qlnk_swap(qlnk, INODE_QLNK(inode));
- INODE_QLNK(inode)->origin = VZ_QUOTAO_QSET;
+ set_qlnk_origin(INODE_QLNK(inode), VZ_QUOTAO_QSET);
return 0;
}
@@ -954,7 +962,7 @@ start:
} else
qmblk = VZ_QUOTA_BAD;
if (!vzquota_inode_qmblk_set(inode, qmblk, &qlnk)){/* success */
- INODE_QLNK(inode)->origin = VZ_QUOTAO_ACT;
+ set_qlnk_origin(INODE_QLNK(inode), VZ_QUOTAO_ACT);
break;
}
}
@@ -1003,7 +1011,7 @@ start:
if (vzquota_inode_qmblk_set(inode, qmblk, qlnk))
goto start;
- INODE_QLNK(inode)->origin = VZ_QUOTAO_DTREE;
+ set_qlnk_origin(INODE_QLNK(inode), VZ_QUOTAO_DTREE);
}
static void vzquota_det_qmblk_recalc(struct inode *inode,
@@ -1058,7 +1066,7 @@ start:
set:
if (vzquota_inode_qmblk_set(inode, qmblk, qlnk))
goto start;
- INODE_QLNK(inode)->origin = VZ_QUOTAO_DET;
+ set_qlnk_origin(INODE_QLNK(inode), VZ_QUOTAO_DET);
return;
fail:
@@ -1074,11 +1082,21 @@ fail:
tv.tv_usec -= tvo.tv_usec;
if (tv.tv_sec < timeout)
goto set;
- printk(KERN_ERR "VZDQ: %s, orig %u,"
+ printk(KERN_ERR "VZDQ: %s, orig {%u, %u},"
" dev %s, inode %lu, fs %s\n",
- msg, INODE_QLNK(inode)->origin,
+ msg,
+ INODE_QLNK(inode)->origin[0],
+ INODE_QLNK(inode)->origin[1],
inode->i_sb->s_id, inode->i_ino,
inode->i_sb->s_type->name);
+ printk(KERN_ERR "i_count %u, ", atomic_read(&inode->i_count));
+ printk(KERN_ERR "i_mode %o, ", inode->i_mode);
+ printk(KERN_ERR "i_state %lx, ", inode->i_state);
+ printk(KERN_ERR "i_flags %x\n", inode->i_flags);
+ printk(KERN_ERR "i_op %p, vfs_empty_iops %p, "
+ "i_fop %p, i_mapping %p\n",
+ inode->i_op, &vfs_empty_iops,
+ inode->i_fop, inode->i_mapping);
if (!cnt++) {
printk(KERN_ERR "current %d (%s), VE %d,"
" time %ld.%06ld\n",
@@ -1304,7 +1322,7 @@ finish:
ret = vzquota_transfer_usage(inode, mask, &qlnew);
if (!ret) {
vzquota_qlnk_swap(&qlnew, INODE_QLNK(inode));
- INODE_QLNK(inode)->origin = VZ_QUOTAO_TRANS;
+ set_qlnk_origin(INODE_QLNK(inode), VZ_QUOTAO_TRANS);
}
out_unlock:
vzquota_data_unlock(inode, &data);
@@ -1461,7 +1479,7 @@ int vzquota_on_qmblk(struct super_block
if (!vzquota_inode_qmblk_set(inode, qmblk, &qlnk))
break;
}
- INODE_QLNK(inode)->origin = VZ_QUOTAO_ON;
+ set_qlnk_origin(INODE_QLNK(inode), VZ_QUOTAO_ON);
spin_unlock(&dcache_lock);
if (!err) {
diff --git a/include/linux/vzquota_qlnk.h b/include/linux/vzquota_qlnk.h
index 03fb192..2788c41 100644
--- a/include/linux/vzquota_qlnk.h
+++ b/include/linux/vzquota_qlnk.h
@@ -19,7 +19,7 @@ struct vz_quota_ilink {
struct vz_quota_master *qmblk;
struct vz_quota_ugid *qugid[MAXQUOTAS];
struct list_head list;
- unsigned char origin;
+ unsigned char origin[2];
};
#endif /* _VZDQUOTA_QLNK_H */
|
|
|
|
Goto Forum:
Current Time: Mon Oct 28 17:21:20 GMT 2024
Total time taken to generate the page: 0.05176 seconds
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
