OpenVZ Forum


Home » Mailing lists » Devel » gentoo baselayout 1.13 openvz modifications
gentoo baselayout 1.13 openvz modifications [message #9789] Mon, 22 January 2007 14:58 Go to next message
kir is currently offline  kir
Messages: 1645
Registered: August 2005
Location: Moscow, Russia
Senior Member

Hello,

I was checking the stuff added to Gentoo's baselayout 1.13 to make it
compatible with VPS systems like Linux-VServer or OpenVZ.

Everything looks great, the only minor problem I found is this code in
bootmisc:

if [[ $(uname) == "Linux" ]] && ! is_vps_sys ; then
# BSD has it's own sysctl init script
if [[ -e /etc/sysctl.conf ]] ; then
ebegin $"Configuring kernel parameters"
sysctl -q -p /etc/sysctl.conf
eend $?
fi
fi

The problem here is in OpenVZ some of sysctl variables are virtualized,
i.e. you can set it from inside your VE. Usually this is not needed, and
not too many people do that, but still if there is /etc/sysctl.conf
people expect that it will be applied during VE start.

Surely this is minor problem and it does not cry for fixing it now.
Still, at the very least it would be helpful to add FIXME or TODO-like
comment in the code.

Regards,
Kir.


PS version checked is baselayout-1.13.0_alpha12
Re: gentoo baselayout 1.13 openvz modifications [message #9874 is a reply to message #9789] Fri, 26 January 2007 16:43 Go to previous message
hollow is currently offline  hollow
Messages: 2
Registered: December 2006
Junior Member
On Friday 26 January 2007 17:02, Roy Marples wrote:
> On Mon, 22 Jan 2007 17:58:05 +0300
>
> Kir Kolyshkin <kir@openvz.org> wrote:
> > I was checking the stuff added to Gentoo's baselayout 1.13 to make it
> > compatible with VPS systems like Linux-VServer or OpenVZ.
> >
> > Everything looks great, the only minor problem I found is this code
> > in bootmisc:
> >
> > if [[ $(uname) == "Linux" ]] && ! is_vps_sys ; then
> > # BSD has it's own sysctl init script
> > if [[ -e /etc/sysctl.conf ]] ; then
> > ebegin $"Configuring kernel parameters"
> > sysctl -q -p /etc/sysctl.conf
> > eend $?
> > fi
> > fi
> >
> > The problem here is in OpenVZ some of sysctl variables are
> > virtualized, i.e. you can set it from inside your VE. Usually this is
> > not needed, and not too many people do that, but still if there
> > is /etc/sysctl.conf people expect that it will be applied during VE
> > start.
>
> Hollow asked for that for a reason. I'll assume that he's on the
> vserver-devs@gentoo.org mailing list and he'll tell me why.
>
> Otherwise I have no problem with punting it myself.
>
> Thanks
>
> Roy

Yeah, we can punt that...
Re: gentoo baselayout 1.13 openvz modifications [message #9882 is a reply to message #9789] Fri, 26 January 2007 16:02 Go to previous message
Roy Marples is currently offline  Roy Marples
Messages: 1
Registered: January 2007
Junior Member
On Mon, 22 Jan 2007 17:58:05 +0300
Kir Kolyshkin <kir@openvz.org> wrote:
> I was checking the stuff added to Gentoo's baselayout 1.13 to make it
> compatible with VPS systems like Linux-VServer or OpenVZ.
>
> Everything looks great, the only minor problem I found is this code
> in bootmisc:
>
> if [[ $(uname) == "Linux" ]] && ! is_vps_sys ; then
> # BSD has it's own sysctl init script
> if [[ -e /etc/sysctl.conf ]] ; then
> ebegin $"Configuring kernel parameters"
> sysctl -q -p /etc/sysctl.conf
> eend $?
> fi
> fi
>
> The problem here is in OpenVZ some of sysctl variables are
> virtualized, i.e. you can set it from inside your VE. Usually this is
> not needed, and not too many people do that, but still if there
> is /etc/sysctl.conf people expect that it will be applied during VE
> start.

Hollow asked for that for a reason. I'll assume that he's on the
vserver-devs@gentoo.org mailing list and he'll tell me why.

Otherwise I have no problem with punting it myself.

Thanks

Roy
Previous Topic: Re: + user-ns-implement-user-ns-unshare-remove-config_user_ns.patch added to -mm tree
Next Topic: [PATCH 0/59] Cleanup sysctl
Goto Forum:
  


Current Time: Sat Apr 13 19:44:31 GMT 2024

Total time taken to generate the page: 0.01490 seconds