| Re: [PATCH 2/5] fixing errors handling during pci_driver resume stage [ata] [message #9617 is a reply to message #9537] |
Fri, 12 January 2007 23:50  |
Grant Grundler
Messages: 1
Registered: January 2007
|
Junior Member |
|
|
On Tue, Jan 09, 2007 at 12:01:28PM +0300, Dmitriy Monakhov wrote:
> ata pci drivers have to return correct error code during resume stage in
> case of errors.
...
> @@ -6246,8 +6253,10 @@ int ata_pci_device_suspend(struct pci_de
> int ata_pci_device_resume(struct pci_dev *pdev)
> {
> struct ata_host *host = dev_get_drvdata(&pdev->dev);
> + int err;
>
> - ata_pci_device_do_resume(pdev);
> + if ((err = ata_pci_device_do_resume(pdev)))
> + return err;
nit: in every other case I looked at you did:
err = foo()
if (err) ...
Can you make that consistent here too?
thanks,
grant
|
|
|
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
