OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 1/5] fixing errors handling during pci_driver resume stage [net]
Re: [PATCH 1/5] fixing errors handling during pci_driver resume stage [net] [message #9568 is a reply to message #9557] Wed, 10 January 2007 11:11 Go to previous message
Dmitriy Monakhov is currently offline  Dmitriy Monakhov
Messages: 52
Registered: October 2006
Member
Stephen Hemminger <shemminger@osdl.org> writes:

> On Tue, 09 Jan 2007 12:01:14 +0300
> Dmitriy Monakhov <dmonakhov@openvz.org> wrote:
>
>> network pci drivers have to return correct error code during resume stage in
>> case of errors.
>> Signed-off-by: Dmitriy Monakhov <dmonakhov@openvz.org>
>> -----
>
> Please don't introduce one dev_err() call into a device driver if all the other
> error printout's use a different interface.
Ok. It was wrong decision to fix all affected drivers in one patchset.
Especially without respect to concrete driver specific.
I'll try to rewrite it in more slowly but (i hope) more correct way
>
> --
> Stephen Hemminger <shemminger@osdl.org>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

Report message to a moderator

[Message index]
 
Read Message
Read Message
Read Message
Previous Topic: [PATCH 5/5] fixing errors handling during pci_driver resume stage [serial]
Next Topic: [PATCH] incorrect direct io error handling
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ] [ PDF ]

Current Time: Fri Aug 01 00:46:39 GMT 2025

Total time taken to generate the page: 0.39820 seconds
Powered by FUDforum Powered by Virtuozzo Containers