OpenVZ Forum: Devel » [PATCH] incorrect error handling inside generic_file_direct

Home » Mailing lists » Devel » [PATCH] incorrect error handling inside generic_file_direct_write

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] incorrect error handling inside generic_file_direct_write [message #8967 is a reply to message #8966]

Tue, 12 December 2006 09:52

Andrew Morton
Messages: 127
Registered: December 2005

Senior Member

On Tue, 12 Dec 2006 15:20:52 +0300
Dmitriy Monakhov <dmonakhov@sw.ru> wrote:

> > XFS (at least) can call generic_file_direct_write() with i_mutex not held.
> > And vmtruncate() expects i_mutex to be held.
> >
> > I guess a suitable solution would be to push this problem back up to the
> > callers: let them decide whether to run vmtruncate() and if so, to ensure
> > that i_mutex is held.
> >
> > The existence of generic_file_aio_write_nolock() makes that rather messy
> > though.
> This means we may call generic_file_aio_write_nolock() without i_mutex, right?
> but call trace is :
> generic_file_aio_write_nolock()
> ->generic_file_buffered_write() /* i_mutex not held here */
> but according to filemaps locking rules: mm/filemap.c:77
> ..
> * ->i_mutex (generic_file_buffered_write)
> * ->mmap_sem (fault_in_pages_readable->do_page_fault)
> ..
> I'm confused a litle bit, where is the truth?

xfs_write() calls generic_file_direct_write() without taking i_mutex for
O_DIRECT writes.

Report message to a moderator

[Message index]

		[PATCH] incorrect error handling inside generic_file_direct_write By: Dmitriy Monakhov on Mon, 11 December 2006 10:34
		Re: [PATCH] incorrect error handling inside generic_file_direct_write By: dev on Mon, 11 December 2006 12:27
		Re: [PATCH] incorrect error handling inside generic_file_direct_write By: Andrew Morton on Mon, 11 December 2006 20:40
		Re: [PATCH] incorrect error handling inside generic_file_direct_write By: Dmitriy Monakhov on Tue, 12 December 2006 06:22
		Re: [PATCH] incorrect error handling inside generic_file_direct_write By: Andrew Morton on Tue, 12 December 2006 06:36
		Re: [PATCH] incorrect error handling inside generic_file_direct_write By: Dmitriy Monakhov on Tue, 12 December 2006 09:20
		Re: [PATCH] incorrect error handling inside generic_file_direct_write By: Andrew Morton on Tue, 12 December 2006 09:52
		Re: [PATCH] incorrect error handling inside generic_file_direct_write By: Dmitriy Monakhov on Tue, 12 December 2006 10:18
		Re: [PATCH] incorrect error handling inside generic_file_direct_write By: Andrew Morton on Tue, 12 December 2006 10:40
		Re: [PATCH] incorrect error handling inside generic_file_direct_write By: Dmitriy Monakhov on Tue, 12 December 2006 20:14
		RE: [PATCH] incorrect error handling inside generic_file_direct_write By: kenneth.w.chen on Wed, 13 December 2006 02:43
		Re: [PATCH] incorrect error handling inside generic_file_direct_write By: Christoph Hellwig on Fri, 15 December 2006 10:43
		RE: [PATCH] incorrect error handling inside generic_file_direct_write By: kenneth.w.chen on Fri, 15 December 2006 18:53
		Re: [PATCH] incorrect error handling inside generic_file_direct_write By: Christoph Hellwig on Tue, 02 January 2007 11:17

Previous Topic:	[PATCH] xt_hashlimit.c: fix typo
Next Topic:	vzmigrate filesystem rsync correction

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Mar 20 10:46:54 GMT 2026

Total time taken to generate the page: 1.84301 seconds