OpenVZ Forum: Devel » Re: Re: Network virtualization/isolation

Home » Mailing lists » Devel » Re: Re: Network virtualization/isolation

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: Network virtualization/isolation [message #8721 is a reply to message #8719]

Mon, 04 December 2006 16:52

ebiederm
Messages: 1354
Registered: February 2006

Senior Member

Dmitry Mishin <dim@openvz.org> writes:

> On Monday 04 December 2006 18:35, Eric W. Biederman wrote:
> [skip]
>> Where and when you look to find the network namespace that applies to
>> a packet is the primary difference between the OpenVZ L2
>> implementation and my L2 implementation.
>>
>> If there is a better and less intrusive while still being obvious
>> method I am all for it. I do not like the OpenVZ thing of doing the
>> lookup once and then stashing the value in current and the special
>> casing the exceptions.
> Why?

I like it when things are obvious and not implied.

The implementations seems to favor fewer lines of code touched over
maintainability of the code. Which if you are maintaining out of
tree code is fine. At leas that was my impression last time
I looked at the code.

I know there are a lot of silly things in the existing implementations
because they were initially written without the expectation of being
able to merge the code into the main kernel. This resulted in some
non-general interfaces, and a preference for patches that touch
as few lines of code as possible.

Anyway this has bit has been discussed before and we can discuss it
seriously in the context of patch review.

Eric

Report message to a moderator

[Message index]

		Re: Re: Network virtualization/isolation By: Daniel Lezcano on Wed, 29 November 2006 22:10
		Re: Re: Network virtualization/isolation By: Vlad Yasevich on Thu, 30 November 2006 16:15
		Re: Network virtualization/isolation By: jamal on Sun, 03 December 2006 12:26
		Network virtualization/isolation By: jamal on Sun, 03 December 2006 14:13
		Re: Network virtualization/isolation By: ebiederm on Mon, 04 December 2006 12:15
		Re: Network virtualization/isolation By: jamal on Mon, 04 December 2006 13:44
		Re: Network virtualization/isolation By: ebiederm on Mon, 04 December 2006 15:35
		Re: Network virtualization/isolation By: Mishin Dmitry on Mon, 04 December 2006 16:00
		Re: Network virtualization/isolation By: ebiederm on Mon, 04 December 2006 16:52
		Re: Re: Network virtualization/isolation By: dev on Wed, 06 December 2006 11:45
		Re: Re: Network virtualization/isolation By: Herbert Poetzl on Wed, 06 December 2006 18:30
		Re: Re: Network virtualization/isolation By: ebiederm on Fri, 08 December 2006 19:57
		Re: Re: Network virtualization/isolation By: Herbert Poetzl on Sat, 09 December 2006 03:50
		Re: Re: Network virtualization/isolation By: Tomasz Torcz on Sat, 09 December 2006 11:27
		Re: Re: Network virtualization/isolation By: Herbert Poetzl on Sat, 09 December 2006 19:04
		Re: Network virtualization/isolation By: ebiederm on Sat, 25 November 2006 08:21
		Re: Network virtualization/isolation By: Herbert Poetzl on Sun, 26 November 2006 18:34
		Re: Re: Network virtualization/isolation By: Andrew Morton on Sat, 09 December 2006 06:13
		Re: Re: Network virtualization/isolation By: Herbert Poetzl on Sat, 09 December 2006 06:35
		Re: Re: Network virtualization/isolation By: Mishin Dmitry on Sat, 09 December 2006 21:18
		Re: Re: Network virtualization/isolation By: kir on Sat, 09 December 2006 22:34
		Re: Re: Network virtualization/isolation By: Herbert Poetzl on Sun, 10 December 2006 02:21
		Re: Re: Network virtualization/isolation By: ebiederm on Sat, 09 December 2006 08:07
		Re: Network virtualization/isolation By: ebiederm on Sat, 25 November 2006 09:09
		Re: Network virtualization/isolation By: Daniel Lezcano on Tue, 28 November 2006 14:15
		RE: Network virtualization/isolation By: Leonid Grossman on Sat, 25 November 2006 16:35
		Re: Network virtualization/isolation By: ebiederm on Sat, 25 November 2006 19:26
		Re: Network virtualization/isolation By: ebiederm on Sat, 25 November 2006 23:16
		RE: Network virtualization/isolation By: Leonid Grossman on Sat, 25 November 2006 22:17
		Re: Network virtualization/isolation By: Ben Greear on Sun, 26 November 2006 19:41
		Re: Network virtualization/isolation By: ebiederm on Sun, 26 November 2006 20:52
		Re: Network virtualization/isolation By: ebiederm on Tue, 28 November 2006 16:51
		Re: Network virtualization/isolation By: Herbert Poetzl on Tue, 28 November 2006 17:37
		Re: Network virtualization/isolation By: Daniel Lezcano on Tue, 28 November 2006 20:26
		Re: Network virtualization/isolation By: Herbert Poetzl on Wed, 29 November 2006 05:58
		Re: Network virtualization/isolation By: ebiederm on Tue, 28 November 2006 21:50
		Re: Network virtualization/isolation By: Herbert Poetzl on Wed, 29 November 2006 05:54
		Re: Network virtualization/isolation By: Brian Haley on Wed, 29 November 2006 20:21
		Re: Network virtualization/isolation By: jamal on Sun, 03 December 2006 16:58
		Re: Network virtualization/isolation By: ebiederm on Mon, 04 December 2006 16:58
		Re: Network virtualization/isolation By: Herbert Poetzl on Mon, 04 December 2006 17:19
		Re: Network virtualization/isolation By: Daniel Lezcano on Mon, 04 December 2006 17:41
		Re: Network virtualization/isolation By: Daniel Lezcano on Mon, 04 December 2006 10:18
		Re: Network virtualization/isolation By: jamal on Mon, 04 December 2006 13:22
		Re: Network virtualization/isolation By: Herbert Poetzl on Sun, 03 December 2006 16:37

Previous Topic:	[PATCH 2/12] L2 network namespace: network devices virtualization
Next Topic:	Re: [patch 05/20] [Network namespace] Add NS_NET3 to NS_ALL.

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Sep 06 16:54:16 GMT 2025

Total time taken to generate the page: 0.22162 seconds