OpenVZ Forum: Devel » [PATCH] diskquota: 32bit quota tools on 64bit architectures

Home » Mailing lists » Devel » [PATCH] diskquota: 32bit quota tools on 64bit architectures

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures [message #7688 is a reply to message #7678]

Fri, 20 October 2006 12:21

Andi Kleen
Messages: 33
Registered: February 2006

Member

On Friday 20 October 2006 08:30, Vasily Tarasov wrote:
> Andi Kleen wrote:
>
> <snip>
> > Thanks. But the code should be probably common somewhere in fs/*, not
> > duplicated.
> <snip>
>
> Thank you for the comment!
> I'm not sure we should do it. If we move the code in fs/quota.c for example,
> than this code will be compiled for _all_ arhitectures, not only for x86_64 and ia64.
> Of course, we can surround this code by #ifdefs <ARCH>, but I thought this is
> a bad style... Moreover looking through current kernel code, I found out that
> usually code is duplicated in such cases.

Well it doesn't hurt them even if not strictly needed and it's better to have common code for
this. BTW you have to convert over to compat_alloc_* for this as Christoph stated
because set_fs doesn't work on all architectures. Best you use the compat_* types too.

-Andi

Report message to a moderator

[Message index]

		[PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Thu, 19 October 2006 12:30
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Alan Cox on Thu, 19 October 2006 13:03
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: rdunlap on Thu, 19 October 2006 15:20
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Christoph Hellwig on Thu, 19 October 2006 17:29
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Fri, 20 October 2006 06:08
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Arnd Bergmann on Sat, 21 October 2006 16:28
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: David Chinner on Mon, 23 October 2006 02:12
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Mon, 23 October 2006 10:50
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Fri, 20 October 2006 05:58
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Anonymous Coward on Fri, 20 October 2006 06:28
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Christoph Hellwig on Fri, 20 October 2006 07:12
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Andi Kleen on Fri, 20 October 2006 12:21
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Vasily Tarasov on Fri, 15 June 2007 10:41
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Vasily Tarasov on Fri, 15 June 2007 11:00
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Arnd Bergmann on Fri, 15 June 2007 10:43
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Vasily Tarasov on Fri, 15 June 2007 14:48
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Arnd Bergmann on Fri, 15 June 2007 15:24
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Vasily Tarasov on Mon, 18 June 2007 07:41
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Mikael Pettersson on Fri, 15 June 2007 10:03
		Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures By: Mikael Pettersson on Fri, 15 June 2007 11:08

Previous Topic:	[PATCH 16/17] Pid-NS(V3) Remove proc_mnts use for killing inodes
Next Topic:	[PATCH 12/17] Pid-NS(V3) Terminate processes in a ns when reaper is exiting.

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Apr 12 03:48:06 GMT 2026

Total time taken to generate the page: 0.52236 seconds