OpenVZ Forum: Devel » [PATCH] block layer: elv_iosched_show should get elv_list

Home » Mailing lists » Devel » [PATCH] block layer: elv_iosched_show should get elv_list_lock

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] block layer: elv_iosched_show should get elv_list_lock [message #7341 is a reply to message #7340]

Wed, 11 October 2006 11:23

Jens Axboe
Messages: 30
Registered: October 2006

Member

On Wed, Oct 11 2006, Vasily Tarasov wrote:
> elv_iosched_show function iterates other elv_list,
> hence elv_list_lock should be got.

Indeed, that's a bug. Thanks!

> Also the question is: in elv_iosched_show, elv_iosched_store
> q->elevator->elevator_type construction is used without locking
> q->queue_lock. Is it expected?..

As long as the queue doesn't go away, we should be safe enough.

--
Jens Axboe

Report message to a moderator

[Message index]

		[PATCH] block layer: elv_iosched_show should get elv_list_lock By: Anonymous Coward on Wed, 11 October 2006 11:19
		Re: [PATCH] block layer: elv_iosched_show should get elv_list_lock By: Jens Axboe on Wed, 11 October 2006 11:23

Previous Topic:	Remove logmessage when entering VE
Next Topic:	[RFC][PATCH] EXT3: problem with page fault inside a transaction

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Jul 15 21:01:51 GMT 2024

Total time taken to generate the page: 0.03229 seconds