OpenVZ Forum


Home » Mailing lists » Devel » [patch02/05]: Containers(V2)- Generic Linux kernel changes
Re: [patch02/05]: Containers(V2)- Generic Linux kernel changes [message #6579 is a reply to message #6567] Wed, 20 September 2006 16:44 Go to previous messageGo to previous message
Rohit Seth is currently offline  Rohit Seth
Messages: 101
Registered: August 2006
Senior Member
On Wed, 2006-09-20 at 13:27 +0200, Andi Kleen wrote:
> Rohit Seth <rohitseth@google.com> writes:
> > */
> > +#ifdef CONFIG_CONTAINERS
> > + struct container_struct *ctn; /* Pointer to container, may be NULL */
> > +#endif
>
> I still don't think it's a good idea to add a pointer to struct page for this.

I thought last time you supported adding a pointer to struct page (when
you mentioned next gen slab will also consume page->mapping). May be I
missed your point.

> This means any kernel that enables the config would need to carry this significant
> overhead, no matter if containers are used to not.
>
Sure this is non-zero overhead but I think this is the logical place to
track the memory.

> Better would be to store them in some other data structure that is only
> allocated on demand or figure out a way to store them in the sometimes
> not all used fields in struct page.
>

which one...I think the fields in page structure are already getting
doubly used.

> BTW your patchkit seems to be also in wrong order in that when 02 is applied
> it won't compile.

Not sure if I understood that. I've myself tested these patches on
2.6.18-rc6-mm2 kernel and they apply just fine. Are you just trying to
apply 02....if so then that wouldn't suffice.

-rohit

Report message to a moderator

[Message index]
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: Re: [ckrm-tech] [patch00/05]: Containers(V2)- Introduction
Next Topic: Re: [ckrm-tech] [patch00/05]: Containers(V2)- Introduction
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ] [ PDF ]

Current Time: Thu Jul 16 23:01:17 GMT 2026

Total time taken to generate the page: 0.18743 seconds
Powered by FUDforum Powered by Virtuozzo Containers