OpenVZ Forum: Devel » [patch02/05]: Containers(V2)- Generic Linux kernel changes

Home » Mailing lists » Devel » [patch02/05]: Containers(V2)- Generic Linux kernel changes

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [patch02/05]: Containers(V2)- Generic Linux kernel changes [message #6567 is a reply to message #6525]

Wed, 20 September 2006 11:27

Andi Kleen
Messages: 33
Registered: February 2006

Member

Rohit Seth <rohitseth@google.com> writes:
> */
> +#ifdef CONFIG_CONTAINERS
> + struct container_struct *ctn; /* Pointer to container, may be NULL */
> +#endif

I still don't think it's a good idea to add a pointer to struct page for this.
This means any kernel that enables the config would need to carry this significant
overhead, no matter if containers are used to not.

Better would be to store them in some other data structure that is only
allocated on demand or figure out a way to store them in the sometimes
not all used fields in struct page.

BTW your patchkit seems to be also in wrong order in that when 02 is applied
it won't compile.

-Andi

Report message to a moderator

[Message index]

		[patch02/05]: Containers(V2)- Generic Linux kernel changes By: Rohit Seth on Wed, 20 September 2006 02:18
		Re: [patch02/05]: Containers(V2)- Generic Linux kernel changes By: Andi Kleen on Wed, 20 September 2006 11:27
		Re: [patch02/05]: Containers(V2)- Generic Linux kernel changes By: Rohit Seth on Wed, 20 September 2006 16:44
		Re: [patch02/05]: Containers(V2)- Generic Linux kernel changes By: Andi Kleen on Wed, 20 September 2006 18:14
		Re: [patch02/05]: Containers(V2)- Generic Linux kernel changes By: Rohit Seth on Wed, 20 September 2006 18:19
		Re: [patch02/05]: Containers(V2)- Generic Linux kernel changes By: Andi Kleen on Wed, 20 September 2006 18:32
		Re: [patch02/05]: Containers(V2)- Generic Linux kernel changes By: Christoph Lameter on Thu, 21 September 2006 00:23
		Re: [patch02/05]: Containers(V2)- Generic Linux kernel changes By: Rohit Seth on Thu, 21 September 2006 00:37
		Re: [patch02/05]: Containers(V2)- Generic Linux kernel changes By: Christoph Lameter on Thu, 21 September 2006 00:41
		Re: [patch02/05]: Containers(V2)- Generic Linux kernel changes By: Rohit Seth on Thu, 21 September 2006 00:53
		Re: [ckrm-tech] [patch02/05]: Containers(V2)- Generic Linux kernel changes By: Chandra Seetharaman on Thu, 21 September 2006 01:33
		Re: [ckrm-tech] [patch02/05]: Containers(V2)- Generic Linux kernel changes By: Rohit Seth on Thu, 21 September 2006 22:29

Previous Topic:	Re: [ckrm-tech] [patch00/05]: Containers(V2)- Introduction
Next Topic:	Re: [ckrm-tech] [patch00/05]: Containers(V2)- Introduction

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Thu Aug 15 11:28:27 GMT 2024

Total time taken to generate the page: 0.02861 seconds