OpenVZ Forum: Devel » Re: [RFC][PATCH] Add child reaper to struct pspace

Home » Mailing lists » Devel » Re: [RFC][PATCH] Add child reaper to struct pspace

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [RFC][PATCH] Add child reaper to struct pspace [message #6249 is a reply to message #6245]

Tue, 12 September 2006 15:43

ebiederm
Messages: 1354
Registered: February 2006

Senior Member

Kirill Korotaev <dev@sw.ru> writes:

> I guess there will be a need of list of tasks... not of pids only...
> many of loops like do_each_thread()/while_each_thread() has nothing to do with
> pids
> and should be narrowed down to loop through the container.
>
> Does this logic belong to pid_ns? if yes, then it definetely should be called
> task_ns.

Just skimming through I see one or two instances. Where the existing
loop uses do_each_thread()/while_each_thread() that we need to change.

kernel/capabilities.c cap_set_all() is an example.

However what we are trying to achieve there is to iterate through
the same list that kill(-1, ) uses. So we need to replace
do_each_thread()/while_each_thread() with something that will
iterate through everything in the pid namespace.

Most instances of do_each_thread()/while_each_thread() the kernel
really does need a global view, and need to be left unchanged.

Basically the current kernel is short the concept of a process
group of all processes, and uses the concept of a list of all processes
instead.

Since the two concepts of a list of all tasks, and a list of all processes
I can see diverge when we have multiple pid namespaces we need to add
an additional concept, in the kernel.

Do you know an example in that we need to change to implement a pid
namespace that goes beyond iterating through the list of processes
that kill(-1,) uses?

Eric

Report message to a moderator

[Message index]

		Re: [RFC][PATCH] Add child reaper to struct pspace By: dev on Fri, 08 September 2006 17:32
		Re: [RFC][PATCH] Add child reaper to struct pspace By: ebiederm on Sat, 09 September 2006 04:54
		Re: [RFC][PATCH] Add child reaper to struct pspace By: dev on Tue, 12 September 2006 14:41
		Re: [RFC][PATCH] Add child reaper to struct pspace By: ebiederm on Tue, 12 September 2006 15:43
		Re: [RFC][PATCH] Add child reaper to struct pspace By: dev on Sat, 16 September 2006 11:55

Previous Topic:	[Patch05/05]: Containers: Over the memory limit handler
Next Topic:	Re: [RFC][PATCH 1/2] add user namespace [try #2]

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Oct 11 01:04:36 GMT 2025

Total time taken to generate the page: 0.14486 seconds