OpenVZ Forum: Devel » [PATCH] BC: resource beancounters (v4) (added user memory)

Home » Mailing lists » Devel » [PATCH] BC: resource beancounters (v4) (added user memory)

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [ckrm-tech] [PATCH 11/13] BC: vmrss (preparations) [message #6078 is a reply to message #5933]

Thu, 07 September 2006 16:28

Balbir Singh
Messages: 491
Registered: August 2006

Senior Member

Kirill Korotaev wrote:
> This patch does simple things:
> - intruduces an bc_magic field on beancunter to make sure
> union on struct page is correctly used in next patches
> - adds nr_beancounters
> - adds unused_privvmpages variable (counter of privvm pages
> which are not mapped into VM address space and thus potentially
> can be allocated later)
>
> +static inline void privvm_uncharge(struct beancounter *bc, unsigned long sz)
> +{
> + if (unlikely(bc->unused_privvmpages < sz)) {
> + printk("BC: overuncharging %d unused pages: val %lu held %lu\n",
> + bc->bc_id, sz, bc->unused_privvmpages);

I hit this path, when I do not enable CONFIG_BEANCOUNTERS_RSS. I suspect it has
something to do with the code in mod_rss_pages(). I suspect the that
CONFIG_BEANCOUNTERS_RSS needs to be enabled to get the accounting right.

In addition, Could you please make this a warning with KERN_WARNING.

> + sz = bc->unused_privvmpages;
> + }
> + bc->unused_privvmpages -= sz;
> + bc_update_privvmpages(bc);
> +}
> +
--

Balbir Singh,
Linux Technology Center,
IBM Software Labs

Report message to a moderator

[Message index]

		[PATCH] BC: resource beancounters (v4) (added user memory) By: dev on Tue, 05 September 2006 14:59
		[PATCH 1/13] BC: introduce atomic_dec_and_lock_irqsave() By: dev on Tue, 05 September 2006 15:16
		[PATCH 2/13] BC: kconfig By: dev on Tue, 05 September 2006 15:16
		[PATCH 3/17] BC: beancounters core (API) By: dev on Tue, 05 September 2006 15:17
		[PATCH 4/13] BC: context inheriting and changing By: dev on Tue, 05 September 2006 15:19
		[PATCH 5/13] BC: user interface (syscalls) By: dev on Tue, 05 September 2006 15:21
		Re: [ckrm-tech] [PATCH 5/13] BC: user interface (syscalls) By: Balbir Singh on Tue, 05 September 2006 16:04
		Re: [ckrm-tech] [PATCH 5/13] BC: user interface (syscalls) By: Pavel Emelianov on Wed, 06 September 2006 08:29
		Re: [ckrm-tech] [PATCH 5/13] BC: user interface (syscalls) By: Balbir Singh on Wed, 06 September 2006 08:57
		Re: [ckrm-tech] [PATCH 5/13] BC: user interface (syscalls) By: Pavel Emelianov on Wed, 06 September 2006 10:42
		Re: [ckrm-tech] [PATCH 5/13] BC: user interface (syscalls) By: Balbir Singh on Wed, 06 September 2006 13:23
		Re: [ckrm-tech] [PATCH 5/13] BC: user interface (syscalls) By: Balbir Singh on Wed, 06 September 2006 13:45
		Re: [ckrm-tech] [PATCH 5/13] BC: user interface (syscalls) By: dev on Wed, 06 September 2006 14:20
		[PATCH 6/13] BC: kernel memory (core) By: dev on Tue, 05 September 2006 15:21
		[PATCH 7/13] BC: kernel memory (marks) By: dev on Tue, 05 September 2006 15:23
		Re: [PATCH 7/13] BC: kernel memory (marks) By: Cedric Le Goater on Wed, 06 September 2006 14:19
		[PATCH 8/13] BC: locked pages (core) By: dev on Tue, 05 September 2006 15:24
		[PATCH 9/13] BC: locked pages (charge hooks) By: dev on Tue, 05 September 2006 15:25
		Re: [PATCH 9/13] BC: locked pages (charge hooks) By: Nick Piggin on Wed, 06 September 2006 03:43
		Re: [PATCH 9/13] BC: locked pages (charge hooks) By: Pavel Emelianov on Wed, 06 September 2006 08:45
		Re: [PATCH 9/13] BC: locked pages (charge hooks) By: Nick Piggin on Wed, 06 September 2006 09:41
		Re: [ckrm-tech] [PATCH 9/13] BC: locked pages (charge hooks) By: dev on Wed, 06 September 2006 14:16
		[PATCH 10/13] BC: privvm pages By: dev on Tue, 05 September 2006 15:26
		[PATCH 11/13] BC: vmrss (preparations) By: dev on Tue, 05 September 2006 15:28
		Re: [PATCH 11/13] BC: vmrss (preparations) By: Cedric Le Goater on Tue, 05 September 2006 22:09
		Re: [PATCH 11/13] BC: vmrss (preparations) By: dev on Wed, 06 September 2006 13:56
		Re: [ckrm-tech] [PATCH 11/13] BC: vmrss (preparations) By: Balbir Singh on Thu, 07 September 2006 16:28
		[PATCH 12/13] BC: vmrss (core) By: dev on Tue, 05 September 2006 15:28
		[PATCH 13/13] BC: vmrss (charges) By: dev on Tue, 05 September 2006 15:29
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Balbir Singh on Tue, 05 September 2006 16:53
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Wed, 06 September 2006 08:34
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: dev on Wed, 06 September 2006 13:04
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Balbir Singh on Wed, 06 September 2006 19:17
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Wed, 06 September 2006 22:06
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Balbir Singh on Thu, 07 September 2006 03:08
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Fri, 08 September 2006 07:33
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Dave Hansen on Fri, 08 September 2006 15:43
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Balbir Singh on Fri, 08 September 2006 18:26
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Mon, 11 September 2006 06:56
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Balbir Singh on Mon, 11 September 2006 07:54
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Mon, 11 September 2006 08:13
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Balbir Singh on Mon, 11 September 2006 08:19
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Tue, 12 September 2006 10:40
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Balbir Singh on Tue, 12 September 2006 12:01
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Wed, 13 September 2006 13:39
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Tue, 12 September 2006 10:39
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Srivatsa Vaddagiri on Mon, 11 September 2006 10:21
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Tue, 12 September 2006 10:35
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Mon, 11 September 2006 18:49
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Tue, 12 September 2006 10:48
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Tue, 12 September 2006 23:58
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Wed, 13 September 2006 08:06
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Srivatsa Vaddagiri on Wed, 13 September 2006 12:15
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Wed, 13 September 2006 13:35
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Wed, 13 September 2006 22:31
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Thu, 14 September 2006 07:53
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Balbir Singh on Thu, 14 September 2006 08:06
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Thu, 14 September 2006 13:02
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Fri, 15 September 2006 00:02
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Fri, 15 September 2006 07:21
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: dev on Fri, 15 September 2006 08:46
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Mon, 18 September 2006 23:51
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Thu, 14 September 2006 23:42
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Fri, 15 September 2006 07:15
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: dev on Fri, 15 September 2006 08:51
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Fri, 15 September 2006 11:15
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Balbir Singh on Mon, 18 September 2006 08:25
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Mon, 18 September 2006 08:56
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Balbir Singh on Mon, 18 September 2006 11:20
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Mon, 18 September 2006 11:32
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Tue, 19 September 2006 00:05
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Tue, 19 September 2006 08:04
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Balbir Singh on Mon, 18 September 2006 11:27
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Mon, 18 September 2006 12:37
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Tue, 19 September 2006 00:08
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Tue, 19 September 2006 08:06
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Mon, 18 September 2006 23:48
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Mon, 11 September 2006 18:44
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: dev on Fri, 15 September 2006 08:53
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Mon, 18 September 2006 23:57
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Fri, 08 September 2006 19:23
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Rohit Seth on Fri, 08 September 2006 21:43
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Mon, 11 September 2006 18:25
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Rohit Seth on Mon, 11 September 2006 19:10
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Mon, 11 September 2006 19:42
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Rohit Seth on Mon, 11 September 2006 23:58
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Balbir Singh on Tue, 12 September 2006 09:53
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Tue, 12 September 2006 23:54
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Rohit Seth on Wed, 13 September 2006 00:39
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Wed, 13 September 2006 01:10
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Rohit Seth on Wed, 13 September 2006 01:25
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Srivatsa Vaddagiri on Wed, 13 September 2006 04:41
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Wed, 13 September 2006 22:20
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Rohit Seth on Thu, 14 September 2006 01:22
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Thu, 14 September 2006 23:13
		Re: Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: kir on Mon, 11 September 2006 19:47
		Re: Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Rohit Seth on Tue, 12 September 2006 00:28
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Srivatsa Vaddagiri on Tue, 12 September 2006 10:44
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Rohit Seth on Tue, 12 September 2006 17:22
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Srivatsa Vaddagiri on Tue, 12 September 2006 17:40
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Wed, 13 September 2006 00:02
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Rohit Seth on Wed, 13 September 2006 00:43
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Wed, 13 September 2006 01:13
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Wed, 06 September 2006 21:47
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Dave Hansen on Fri, 08 September 2006 15:33
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Dave Hansen on Tue, 05 September 2006 17:46
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Balbir Singh on Tue, 05 September 2006 18:28
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Rohit Seth on Wed, 06 September 2006 00:17
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Dave Hansen on Fri, 08 September 2006 15:30
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Rohit Seth on Fri, 08 September 2006 17:10
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Shailabh Nagar on Fri, 08 September 2006 17:26
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: dev on Wed, 06 September 2006 13:54
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Wed, 06 September 2006 21:54
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Thu, 07 September 2006 07:29
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Thu, 07 September 2006 19:16
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Fri, 08 September 2006 07:22
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Fri, 08 September 2006 19:07
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Mon, 11 September 2006 07:02
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Srivatsa Vaddagiri on Mon, 11 September 2006 13:04
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Tue, 12 September 2006 10:24
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Srivatsa Vaddagiri on Tue, 12 September 2006 10:29
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Tue, 12 September 2006 11:06
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Srivatsa Vaddagiri on Tue, 12 September 2006 12:04
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Mon, 11 September 2006 18:47
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Thu, 07 September 2006 19:29
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Pavel Emelianov on Fri, 08 September 2006 07:26
		Re: [ckrm-tech] [PATCH] BC: resource beancounters (v4) (added user memory) By: Chandra Seetharaman on Fri, 08 September 2006 19:10

Previous Topic:	Acks for 3 pid-namespace patches
Next Topic:	[Patch 01/05]- Containers: Documentation on using containers

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Aug 29 00:58:33 GMT 2025

Total time taken to generate the page: 0.16882 seconds