| Re: [PATCH 1/7] introduce atomic_dec_and_lock_irqsave() [message #5770 is a reply to message #5740] |
Wed, 30 August 2006 09:59   |
Roman Zippel
Messages: 4
Registered: August 2006
|
Junior Member |
|
|
Hi,
On Tue, 29 Aug 2006, Kirill Korotaev wrote:
> --- ./kernel/user.c.dlirq 2006-07-10 12:39:20.000000000 +0400
> +++ ./kernel/user.c 2006-08-28 11:08:56.000000000 +0400
> @@ -108,15 +108,12 @@ void free_uid(struct user_struct *up)
> if (!up)
> return;
>
> - local_irq_save(flags);
> - if (atomic_dec_and_lock(&up->__count, &uidhash_lock)) {
> + if (atomic_dec_and_lock_irqsave(&up->__count, &uidhash_lock, flags)) {
> uid_hash_remove(up);
> spin_unlock_irqrestore(&uidhash_lock, flags);
> key_put(up->uid_keyring);
> key_put(up->session_keyring);
> kmem_cache_free(uid_cachep, up);
> - } else {
> - local_irq_restore(flags);
> }
> }
Why does this need protection against interrupts?
bye, Roman
|
|
|
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
