OpenVZ Forum: Devel » [PATCH] BC: resource beancounters (v2)

Home » Mailing lists » Devel » [PATCH] BC: resource beancounters (v2)

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 2/6] BC: beancounters core (API) [message #5550 is a reply to message #5544]

Wed, 23 August 2006 11:37

Andi Kleen
Messages: 33
Registered: February 2006

Member

On Wednesday 23 August 2006 13:03, Kirill Korotaev wrote:

> +#ifdef CONFIG_BEANCOUNTERS
> +extern struct hlist_head bc_hash[];
> +extern spinlock_t bc_hash_lock;

I wonder who pokes into that hash from other files? Looks a bit dangerous.

> +void __put_beancounter(struct beancounter *bc);
> +static inline void put_beancounter(struct beancounter *bc)
> +{
> + __put_beancounter(bc);
> +}

The wrapper seems pointless too.

The file could use a overview comment what the various counter
types actually are.

> + bc_print_id(bc, uid, sizeof(uid));
> + printk(KERN_WARNING "BC %s %s warning: %s "

Doesn't this need some rate limiting? Or can it be only triggered
by code bugs?

> + bc = &default_beancounter;
> + memset(bc, 0, sizeof(default_beancounter));

You don't trust the BSS to be zero? @)

-Andi

Report message to a moderator

[Message index]

		[PATCH] BC: resource beancounters (v2) By: dev on Wed, 23 August 2006 10:44
		[PATCH 1/6] BC: kconfig By: dev on Wed, 23 August 2006 10:59
		Re: [PATCH 1/6] BC: kconfig By: Alexey Dobriyan on Wed, 23 August 2006 13:04
		Re: [PATCH 1/6] BC: kconfig By: Dave Hansen on Wed, 23 August 2006 22:04
		Re: [PATCH 1/6] BC: kconfig By: Matt Helsley on Wed, 23 August 2006 22:13
		Re: [PATCH 1/6] BC: kconfig By: dev on Fri, 25 August 2006 11:27
		Re: [PATCH 1/6] BC: kconfig By: dev on Fri, 25 August 2006 11:31
		Re: [PATCH 1/6] BC: kconfig By: rdunlap on Wed, 23 August 2006 22:29
		Re: [PATCH 1/6] BC: kconfig By: Matt Helsley on Wed, 23 August 2006 22:27
		Re: [PATCH 1/6] BC: kconfig By: Chandra Seetharaman on Thu, 24 August 2006 00:23
		Re: [ckrm-tech] [PATCH 1/6] BC: kconfig By: dev on Thu, 24 August 2006 11:47
		Re: [ckrm-tech] [PATCH 1/6] BC: kconfig By: Matt Helsley on Thu, 24 August 2006 22:23
		[PATCH 2/6] BC: beancounters core (API) By: dev on Wed, 23 August 2006 11:00
		Re: [PATCH 2/6] BC: beancounters core (API) By: Andi Kleen on Wed, 23 August 2006 11:37
		Re: [PATCH 2/6] BC: beancounters core (API) By: dev on Wed, 23 August 2006 13:25
		Re: [PATCH 2/6] BC: beancounters core (API) By: Andi Kleen on Wed, 23 August 2006 13:48
		Re: [PATCH 2/6] BC: beancounters core (API) By: dev on Wed, 23 August 2006 13:46
		Re: [PATCH 2/6] BC: beancounters core (API) By: Alexey Dobriyan on Wed, 23 August 2006 13:53
		Re: [PATCH 2/6] BC: beancounters core (API) By: Matt Helsley on Wed, 23 August 2006 22:05
		Re: [PATCH 2/6] BC: beancounters core (API) By: Alexey Dobriyan on Wed, 23 August 2006 13:30
		Re: [PATCH 2/6] BC: beancounters core (API) By: Andrew Morton on Wed, 23 August 2006 16:42
		Re: [PATCH 2/6] BC: beancounters core (API) By: Oleg Nesterov on Thu, 24 August 2006 11:09
		Re: [PATCH 2/6] BC: beancounters core (API) By: dev on Thu, 24 August 2006 12:03
		Re: [PATCH 2/6] BC: beancounters core (API) By: Andrew Morton on Thu, 24 August 2006 15:00
		Re: [PATCH 2/6] BC: beancounters core (API) By: dev on Fri, 25 August 2006 10:51
		Re: [PATCH 2/6] BC: beancounters core (API) By: Oleg Nesterov on Thu, 24 August 2006 17:09
		[PATCH 3/6] BC: context inheriting and changing By: dev on Wed, 23 August 2006 11:02
		[PATCH 4/6] BC: user interface (syscalls) By: dev on Wed, 23 August 2006 11:03
		Re: [PATCH 4/6] BC: user interface (syscalls) By: dev on Wed, 23 August 2006 13:40
		Re: [PATCH 4/6] BC: user interface (syscalls) By: Andrew Morton on Wed, 23 August 2006 16:50
		Re: [PATCH 4/6] BC: user interface (syscalls) By: Alan Cox on Wed, 23 August 2006 17:08
		Re: [PATCH 4/6] BC: user interface (syscalls) By: Andrew Morton on Thu, 24 August 2006 04:35
		Re: [PATCH 4/6] BC: user interface (syscalls) By: Alan Cox on Thu, 24 August 2006 10:42
		Re: [PATCH 4/6] BC: user interface (syscalls) By: Alexey Dobriyan on Thu, 24 August 2006 13:08
		Re: [PATCH 4/6] BC: user interface (syscalls) By: dev on Fri, 25 August 2006 10:54
		Re: [PATCH 4/6] BC: user interface (syscalls) By: Alexey Dobriyan on Wed, 23 August 2006 13:41
		Re: [PATCH 4/6] BC: user interface (syscalls) By: Chandra Seetharaman on Thu, 24 August 2006 00:30
		[PATCH 5/6] BC: kernel memory accounting (core) By: dev on Wed, 23 August 2006 11:04
		Re: [PATCH 5/6] BC: kernel memory accounting (core) By: Chandra Seetharaman on Thu, 24 August 2006 00:36
		Re: [PATCH 5/6] BC: kernel memory accounting (core) By: Oleg Nesterov on Thu, 24 August 2006 16:59
		Re: [PATCH 5/6] BC: kernel memory accounting (core) By: dev on Fri, 25 August 2006 10:06
		[PATCH 6/6] BC: kernel memory accounting (marks) By: dev on Wed, 23 August 2006 11:05
		Re: [PATCH 6/6] BC: kernel memory accounting (marks) By: Dave Hansen on Wed, 23 August 2006 18:30
		Re: [PATCH 6/6] BC: kernel memory accounting (marks) By: dev on Tue, 29 August 2006 09:52
		Re: [PATCH 6/6] BC: kernel memory accounting (marks) By: Dave Hansen on Tue, 29 August 2006 15:48
		Re: [PATCH 6/6] BC: kernel memory accounting (marks) By: Dave Hansen on Wed, 23 August 2006 23:03
		Re: [PATCH 6/6] BC: kernel memory accounting (marks) By: Geert Uytterhoeven on Thu, 24 August 2006 09:30
		Re: [PATCH 6/6] BC: kernel memory accounting (marks) By: Dave Hansen on Thu, 24 August 2006 15:52
		Re: [PATCH 6/6] BC: kernel memory accounting (marks) By: dev on Tue, 29 August 2006 14:34
		Re: [PATCH 6/6] BC: kernel memory accounting (marks) By: dev on Tue, 29 August 2006 15:53
		Re: [PATCH] BC: resource beancounters (v2) By: Andrew Morton on Wed, 23 August 2006 17:05
		Re: [PATCH] BC: resource beancounters (v2) By: Chandra Seetharaman on Thu, 24 August 2006 00:17
		Re: [PATCH] BC: resource beancounters (v2) By: dev on Fri, 25 August 2006 11:47
		Re: [PATCH] BC: resource beancounters (v2) By: Andrew Morton on Fri, 25 August 2006 14:30
		Re: [PATCH] BC: resource beancounters (v2) By: Andi Kleen on Fri, 25 August 2006 14:48
		Re: [PATCH] BC: resource beancounters (v2) By: dev on Mon, 28 August 2006 08:27
		Re: [PATCH] BC: resource beancounters (v2) By: Nick Piggin on Fri, 25 August 2006 15:14
		Re: BC: resource beancounters (v2) By: Andrey Savochkin on Fri, 25 August 2006 16:30
		Re: BC: resource beancounters (v2) By: Andrew Morton on Fri, 25 August 2006 17:50
		Re: BC: resource beancounters (v2) By: Chandra Seetharaman on Fri, 25 August 2006 19:00
		Re: BC: resource beancounters (v2) By: Rohit Seth on Sat, 26 August 2006 02:15
		Re: BC: resource beancounters (v2) By: Alan Cox on Sat, 26 August 2006 16:16
		Re: BC: resource beancounters (v2) By: Rohit Seth on Mon, 28 August 2006 16:48
		Re: Re: BC: resource beancounters (v2) By: kir on Mon, 28 August 2006 17:40
		Re: Re: BC: resource beancounters (v2) By: Rohit Seth on Mon, 28 August 2006 22:28
		Re: Re: BC: resource beancounters (v2) By: Alan Cox on Tue, 29 August 2006 10:15
		Re: Re: BC: resource beancounters (v2) By: Rohit Seth on Tue, 29 August 2006 17:30
		Re: Re: BC: resource beancounters (v2) By: Alan Cox on Tue, 29 August 2006 18:46
		Re: Re: BC: resource beancounters (v2) By: Rohit Seth on Tue, 29 August 2006 19:15
		Re: [PATCH] BC: resource beancounters (v2) By: dev on Tue, 29 August 2006 15:33
		Re: [PATCH] BC: resource beancounters (v2) By: Balbir Singh on Tue, 29 August 2006 17:08
		Re: [PATCH] BC: resource beancounters (v2) By: Cedric Le Goater on Wed, 23 August 2006 21:00
		Re: [PATCH] BC: resource beancounters (v2) By: Jan Engelhardt on Thu, 24 August 2006 05:52
		Re: [PATCH] BC: resource beancounters (v2) By: Alan Cox on Thu, 24 August 2006 10:38
		Re: [PATCH] BC: resource beancounters (v2) By: Alan Cox on Fri, 25 August 2006 15:36
		Re: [PATCH] BC: resource beancounters (v2) By: Nick Piggin on Sat, 26 August 2006 03:55

Previous Topic:	Re: pspace child_reaper
Next Topic:	Re: pspace child_reaper

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Jul 07 00:52:42 GMT 2025

Total time taken to generate the page: 0.03016 seconds