Re: [PATCH v4] posix timers: allocate timer id per process [message #48516 is a reply to message #48512] |
Fri, 19 October 2012 10:43  |
Eric Dumazet
Messages: 36 Registered: July 2006
|
Member |
|
|
On Fri, 2012-10-19 at 13:38 +0400, Stanislav Kinsbursky wrote:
> 19.10.2012 11:56, Eric Dumazet пишет:
> > I wonder if some applications relied on our idr, assuming they would get
> > low values for their timer id.
> > (We could imagine some applications use a table indexed by the timer id)
>
> Hmm.
> Probably, this particular case can be optimised by tuning min_id to id of
> releasing timer (if id of this timer is less than current->signal min_id).
> Does this approach solves the issue you mentioned above?
Not generally, but I am not sure we want a per signal_struct idr ;)
Really that should be clearly explained in the changelog, so that buggy
applications can have a clue of what happened.
When we changed UDP source port selection being random instead of
sequential, maybe this broke some applications. That was an
implementation choice (with security impact).
|
|
|