OpenVZ Forum: Devel » [PATCH v5 00/14] kmem controller for memcg.

Home » Mailing lists » Devel » [PATCH v5 00/14] kmem controller for memcg.

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v5 04/14] kmem accounting basic infrastructure [message #48460 is a reply to message #48439]

Thu, 18 October 2012 09:04

Glauber Costa
Messages: 916
Registered: October 2011

Senior Member

On 10/18/2012 02:12 AM, Andrew Morton wrote:
> On Tue, 16 Oct 2012 14:16:41 +0400
> Glauber Costa <glommer@parallels.com> wrote:
>
>> This patch adds the basic infrastructure for the accounting of kernel
>> memory. To control that, the following files are created:
>>
>> * memory.kmem.usage_in_bytes
>> * memory.kmem.limit_in_bytes
>> * memory.kmem.failcnt
>
> gargh. "failcnt" is not a word. Who was it who first thought that
> omitting voewls from words improves anything?
>
> Sigh. That pooch is already screwed and there's nothing we can do
> about it now.
>

Dunno =(

>> * memory.kmem.max_usage_in_bytes
>>
>> They have the same meaning of their user memory counterparts. They
>> reflect the state of the "kmem" res_counter.
>>
>> Per cgroup kmem memory accounting is not enabled until a limit is set
>> for the group. Once the limit is set the accounting cannot be disabled
>> for that group. This means that after the patch is applied, no
>> behavioral changes exists for whoever is still using memcg to control
>> their memory usage, until memory.kmem.limit_in_bytes is set for the
>> first time.
>>
>> We always account to both user and kernel resource_counters. This
>> effectively means that an independent kernel limit is in place when the
>> limit is set to a lower value than the user memory. A equal or higher
>> value means that the user limit will always hit first, meaning that kmem
>> is effectively unlimited.
>>
>> People who want to track kernel memory but not limit it, can set this
>> limit to a very high number (like RESOURCE_MAX - 1page - that no one
>> will ever hit, or equal to the user memory)
>>
>>
>> ...
>>
>> +/* internal only representation about the status of kmem accounting. */
>> +enum {
>> + KMEM_ACCOUNTED_ACTIVE = 0, /* accounted by this cgroup itself */
>> +};
>> +
>> +#define KMEM_ACCOUNTED_MASK (1 << KMEM_ACCOUNTED_ACTIVE)
>> +
>> +#ifdef CONFIG_MEMCG_KMEM
>> +static void memcg_kmem_set_active(struct mem_cgroup *memcg)
>> +{
>> + set_bit(KMEM_ACCOUNTED_ACTIVE, &memcg->kmem_accounted);
>> +}
>> +#endif
>
> I don't think memcg_kmem_set_active() really needs to exist. It has a
> single caller and is unlikely to get any additional callers, so just
> open-code it there?
>

Actually they exist as a way to make everything fit in closer to
80-columns without writing the function spanning 10 lines.

I can open code them if you guys prefer.

Report message to a moderator

[Message index]

		[PATCH v5 00/14] kmem controller for memcg. By: Glauber Costa on Tue, 16 October 2012 10:16
		[PATCH v5 03/14] memcg: change defines to an enum By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 03/14] memcg: change defines to an enum By: David Rientjes on Wed, 17 October 2012 21:50
		[PATCH v5 01/14] memcg: Make it possible to use the stock for more than one page. By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 01/14] memcg: Make it possible to use the stock for more than one page. By: akpm on Wed, 17 October 2012 22:11
		Re: [PATCH v5 01/14] memcg: Make it possible to use the stock for more than one page. By: Glauber Costa on Thu, 18 October 2012 08:55
		[PATCH v5 04/14] kmem accounting basic infrastructure By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: Michal Hocko on Tue, 16 October 2012 12:14
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: David Rientjes on Wed, 17 October 2012 22:08
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: Glauber Costa on Thu, 18 October 2012 09:02
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: Tejun Heo on Thu, 18 October 2012 19:47
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: Tejun Heo on Thu, 18 October 2012 19:37
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: akpm on Wed, 17 October 2012 22:12
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: Glauber Costa on Thu, 18 October 2012 09:04
		[PATCH v5 11/14] memcg: allow a memcg with kmem charges to be destructed. By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 11/14] memcg: allow a memcg with kmem charges to be destructed. By: akpm on Wed, 17 October 2012 22:12
		Re: [PATCH v5 11/14] memcg: allow a memcg with kmem charges to be destructed. By: Glauber Costa on Thu, 18 October 2012 09:33
		[PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: KAMEZAWA Hiroyuki on Wed, 17 October 2012 06:40
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: akpm on Wed, 17 October 2012 22:12
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Thu, 18 October 2012 09:16
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: David Rientjes on Thu, 18 October 2012 22:06
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Fri, 19 October 2012 09:10
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: David Rientjes on Fri, 19 October 2012 09:31
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Fri, 19 October 2012 10:00
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: David Rientjes on Wed, 17 October 2012 22:37
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Thu, 18 October 2012 09:23
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: David Rientjes on Thu, 18 October 2012 21:59
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Fri, 19 October 2012 10:08
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: David Rientjes on Fri, 19 October 2012 20:34
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Mon, 22 October 2012 12:34
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Michal Hocko on Mon, 22 October 2012 12:51
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Mon, 22 October 2012 12:52
		[PATCH v5 05/14] Add a __GFP_KMEMCG flag By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 05/14] Add a __GFP_KMEMCG flag By: Michal Hocko on Tue, 16 October 2012 12:15
		Re: [PATCH v5 05/14] Add a __GFP_KMEMCG flag By: David Rientjes on Wed, 17 October 2012 22:09
		[PATCH v5 09/14] memcg: kmem accounting lifecycle management By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 09/14] memcg: kmem accounting lifecycle management By: David Rientjes on Wed, 17 October 2012 23:28
		Re: [PATCH v5 09/14] memcg: kmem accounting lifecycle management By: Michal Hocko on Thu, 18 October 2012 06:14
		Re: [PATCH v5 09/14] memcg: kmem accounting lifecycle management By: Glauber Costa on Thu, 18 October 2012 09:42
		[PATCH v5 10/14] memcg: use static branches when code not in use By: Glauber Costa on Tue, 16 October 2012 10:16
		[PATCH v5 14/14] Add documentation about the kmem controller By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 14/14] Add documentation about the kmem controller By: Michal Hocko on Tue, 16 October 2012 12:23
		Re: [PATCH v5 14/14] Add documentation about the kmem controller By: Christoph Lameter on Tue, 16 October 2012 18:25
		Re: [PATCH v5 14/14] Add documentation about the kmem controller By: Glauber Costa on Tue, 16 October 2012 19:02
		Re: [PATCH v5 14/14] Add documentation about the kmem controller By: Christoph Lameter on Tue, 16 October 2012 19:30
		Re: [PATCH v5 14/14] Add documentation about the kmem controller By: akpm on Wed, 17 October 2012 22:12
		Re: [PATCH v5 14/14] Add documentation about the kmem controller By: Glauber Costa on Thu, 18 October 2012 09:38
		[PATCH v5 13/14] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 13/14] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: akpm on Wed, 17 October 2012 22:12
		Re: [PATCH v5 13/14] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Glauber Costa on Thu, 18 October 2012 09:37
		[PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: Christoph Lameter on Tue, 16 October 2012 15:31
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Tue, 16 October 2012 18:55
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: akpm on Wed, 17 October 2012 22:12
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Thu, 18 October 2012 09:24
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: akpm on Thu, 18 October 2012 20:44
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Thu, 18 October 2012 11:53
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: David Rientjes on Wed, 17 October 2012 22:43
		Re: [PATCH v5 00/14] kmem controller for memcg. By: akpm on Wed, 17 October 2012 22:11
		Re: [PATCH v5 00/14] kmem controller for memcg. By: Glauber Costa on Thu, 18 October 2012 08:52
		Re: [PATCH v5 00/14] kmem controller for memcg. By: akpm on Thu, 18 October 2012 19:21
		Re: [PATCH v5 00/14] kmem controller for memcg. By: Glauber Costa on Fri, 19 October 2012 09:55

Previous Topic:	[PATCH RFC] sched: boost throttled entities on wakeups
Next Topic:	[PATCH v6 01/10] ipc: remove forced assignment of selected message

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Aug 25 22:08:19 GMT 2025

Total time taken to generate the page: 0.06105 seconds