OpenVZ Forum: Devel » [PATCH v4 00/14] kmem controller for memcg.

Home » Mailing lists » Devel » [PATCH v4 00/14] kmem controller for memcg.

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v4 04/14] kmem accounting basic infrastructure [message #48284 is a reply to message #48282]

Thu, 11 October 2012 12:53

Michal Hocko
Messages: 109
Registered: December 2011

Senior Member

On Thu 11-10-12 12:11:19, Michal Hocko wrote:
> On Mon 08-10-12 14:06:10, Glauber Costa wrote:
[...]
> > +static void memcg_kmem_set_active(struct mem_cgroup *memcg)
> > +{
> > + set_bit(KMEM_ACCOUNTED_ACTIVE, &memcg->kmem_accounted);
> > +}
> > +
> > +static bool memcg_kmem_is_accounted(struct mem_cgroup *memcg)
> > +{
> > + return test_bit(KMEM_ACCOUNTED_ACTIVE, &memcg->kmem_accounted);
> > +}
> > +#endif
>
> set_active vs. is_accounted. Is there any reason for inconsistency here?

Ahh, fixed later and 09/14 makes it memcg_kmem_is_active so this is just
a code churn. I think making it memcg_kmem_is_active here would be
better.

--
Michal Hocko
SUSE Labs

Report message to a moderator

[Message index]

		[PATCH v4 00/14] kmem controller for memcg. By: Glauber Costa on Mon, 08 October 2012 10:06
		[PATCH v4 02/14] memcg: Reclaim when more than one page needed. By: Glauber Costa on Mon, 08 October 2012 10:06
		Re: [PATCH v4 02/14] memcg: Reclaim when more than one page needed. By: KAMEZAWA Hiroyuki on Tue, 16 October 2012 03:22
		[PATCH v4 08/14] res_counter: return amount of charges after res_counter_uncharge By: Glauber Costa on Mon, 08 October 2012 10:06
		Re: [PATCH v4 08/14] res_counter: return amount of charges after res_counter_uncharge By: Michal Hocko on Tue, 09 October 2012 15:08
		Re: [PATCH v4 08/14] res_counter: return amount of charges after res_counter_uncharge By: Glauber Costa on Tue, 09 October 2012 15:14
		Re: [PATCH v4 08/14] res_counter: return amount of charges after res_counter_uncharge By: Michal Hocko on Tue, 09 October 2012 15:35
		Re: [PATCH v4 08/14] res_counter: return amount of charges after res_counter_uncharge By: Glauber Costa on Wed, 10 October 2012 09:03
		Re: [PATCH v4 08/14] res_counter: return amount of charges after res_counter_uncharge By: Michal Hocko on Wed, 10 October 2012 11:24
		Re: [PATCH v4 08/14] res_counter: return amount of charges after res_counter_uncharge By: Michal Hocko on Wed, 10 October 2012 11:25
		Re: [PATCH v4 08/14] res_counter: return amount of charges after res_counter_uncharge By: KAMEZAWA Hiroyuki on Tue, 16 October 2012 08:20
		[PATCH v4 12/14] execute the whole memcg freeing in free_worker By: Glauber Costa on Mon, 08 October 2012 10:06
		Re: [PATCH v4 12/14] execute the whole memcg freeing in free_worker By: Michal Hocko on Thu, 11 October 2012 14:21
		[PATCH v4 04/14] kmem accounting basic infrastructure By: Glauber Costa on Mon, 08 October 2012 10:06
		Re: [PATCH v4 04/14] kmem accounting basic infrastructure By: Michal Hocko on Thu, 11 October 2012 10:11
		Re: [PATCH v4 04/14] kmem accounting basic infrastructure By: Michal Hocko on Thu, 11 October 2012 12:53
		Re: [PATCH v4 04/14] kmem accounting basic infrastructure By: Michal Hocko on Thu, 11 October 2012 13:38
		Re: [PATCH v4 04/14] kmem accounting basic infrastructure By: Glauber Costa on Fri, 12 October 2012 07:36
		Re: [PATCH v4 04/14] kmem accounting basic infrastructure By: Michal Hocko on Fri, 12 October 2012 08:27
		[PATCH v4 14/14] Add documentation about the kmem controller By: Glauber Costa on Mon, 08 October 2012 10:06
		Re: [PATCH v4 14/14] Add documentation about the kmem controller By: Michal Hocko on Thu, 11 October 2012 14:35
		Re: [PATCH v4 14/14] Add documentation about the kmem controller By: Glauber Costa on Fri, 12 October 2012 07:53
		Re: [PATCH v4 14/14] Add documentation about the kmem controller By: Michal Hocko on Fri, 12 October 2012 08:44
		Re: [PATCH v4 14/14] Add documentation about the kmem controller By: KAMEZAWA Hiroyuki on Wed, 17 October 2012 07:29
		[PATCH v4 01/14] memcg: Make it possible to use the stock for more than one page. By: Glauber Costa on Mon, 08 October 2012 10:06
		[PATCH v4 03/14] memcg: change defines to an enum By: Glauber Costa on Mon, 08 October 2012 10:06
		[PATCH v4 05/14] Add a __GFP_KMEMCG flag By: Glauber Costa on Mon, 08 October 2012 10:06
		Re: [PATCH v4 05/14] Add a __GFP_KMEMCG flag By: Michal Hocko on Tue, 09 October 2012 15:04
		[PATCH v4 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Mon, 08 October 2012 10:06
		Re: [PATCH v4 06/14] memcg: kmem controller infrastructure By: Michal Hocko on Thu, 11 October 2012 12:42
		Re: [PATCH v4 06/14] memcg: kmem controller infrastructure By: Michal Hocko on Thu, 11 October 2012 12:56
		Re: [PATCH v4 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Fri, 12 October 2012 07:45
		Re: [PATCH v4 06/14] memcg: kmem controller infrastructure By: Michal Hocko on Fri, 12 October 2012 08:39
		Re: [PATCH v4 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Fri, 12 October 2012 08:44
		Re: [PATCH v4 06/14] memcg: kmem controller infrastructure By: Michal Hocko on Fri, 12 October 2012 08:57
		Re: [PATCH v4 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Fri, 12 October 2012 09:13
		Re: [PATCH v4 06/14] memcg: kmem controller infrastructure By: Michal Hocko on Fri, 12 October 2012 09:47
		Re: [PATCH v4 06/14] memcg: kmem controller infrastructure By: KAMEZAWA Hiroyuki on Tue, 16 October 2012 08:00
		[PATCH v4 11/14] memcg: allow a memcg with kmem charges to be destructed. By: Glauber Costa on Mon, 08 October 2012 10:06
		[PATCH v4 13/14] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Glauber Costa on Mon, 08 October 2012 10:06
		[PATCH v4 07/14] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Mon, 08 October 2012 10:06
		[PATCH v4 10/14] memcg: use static branches when code not in use By: Glauber Costa on Mon, 08 October 2012 10:06
		Re: [PATCH v4 10/14] memcg: use static branches when code not in use By: Michal Hocko on Thu, 11 October 2012 13:40
		Re: [PATCH v4 10/14] memcg: use static branches when code not in use By: Glauber Costa on Fri, 12 October 2012 07:47
		Re: [PATCH v4 10/14] memcg: use static branches when code not in use By: KAMEZAWA Hiroyuki on Tue, 16 October 2012 08:48
		[PATCH v4 09/14] memcg: kmem accounting lifecycle management By: Glauber Costa on Mon, 08 October 2012 10:06
		Re: [PATCH v4 09/14] memcg: kmem accounting lifecycle management By: Michal Hocko on Thu, 11 October 2012 13:11
		Re: [PATCH v4 09/14] memcg: kmem accounting lifecycle management By: Glauber Costa on Fri, 12 October 2012 07:47
		Re: [PATCH v4 09/14] memcg: kmem accounting lifecycle management By: Michal Hocko on Fri, 12 October 2012 08:41
		Re: [PATCH v4 09/14] memcg: kmem accounting lifecycle management By: KAMEZAWA Hiroyuki on Tue, 16 October 2012 08:41

Previous Topic:	[PATCH v5 12/14] execute the whole memcg freeing in free_worker
Next Topic:	[RFC PATCH v2] posix timers: allocate timer id per task

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Sep 13 00:55:15 GMT 2024

Total time taken to generate the page: 0.04982 seconds