OpenVZ Forum: Devel » [PATCH v3] SUNRPC: set desired file system root before connecting local transports

Home » Mailing lists » Devel » [PATCH v3] SUNRPC: set desired file system root before connecting local transports

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports [message #48252 is a reply to message #48251]

Tue, 09 October 2012 20:20

ebiederm
Messages: 1354
Registered: February 2006

Senior Member

"Myklebust, Trond" <Trond.Myklebust@netapp.com> writes:

> On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote:
>> Cc'ing Eric since I seem to recall he suggested doing it this way?

Yes. On second look setting fs->root won't work. We need to change fs.
The problem is that by default all kernel threads share fs so changing
fs->root will have non-local consequences.

I very much believe we want if at all possible to perform a local
modification.

Changing fs isn't all that different from what devtmpfs is doing.

>> Seems OK to me, but maybe that swap_root should be in common code? (Or
>> maybe we could use set_fs_root()?)
>>
>> I'm assuming it's up to Trond to take this.--b.
>
> I'm reluctant to do that at this time since the original proposal was
> precisely that of export set_fs_root() and using it around the AF_LOCAL
> socket bind. That proposal was NACKed by Al Viro.

> If Al is OK with the idea of us creating a private version of
> set_fs_root, then I'd like to see an official Acked-by: that we can
> append to this commit.

Eric

Report message to a moderator

[Message index]

		[PATCH v3] SUNRPC: set desired file system root before connecting local transports By: Stanislav Kinsbursky on Mon, 08 October 2012 10:55
		Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports By: bfields on Tue, 09 October 2012 19:35
		Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports By: Myklebust, Trond on Tue, 09 October 2012 19:49
		Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports By: ebiederm on Tue, 09 October 2012 20:20
		Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports By: bfields on Tue, 09 October 2012 22:31
		Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports By: ebiederm on Tue, 09 October 2012 22:47
		Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports By: bfields on Wed, 10 October 2012 01:23
		Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports By: Stanislav Kinsbursky on Wed, 10 October 2012 10:32
		Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports By: bfields on Fri, 26 October 2012 17:52
		Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports By: ebiederm on Wed, 10 October 2012 02:00
		Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports By: Stanislav Kinsbursky on Wed, 10 October 2012 05:09
		Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports By: Stanislav Kinsbursky on Wed, 10 October 2012 05:03

Previous Topic:	[PATCH v3 00/12] fuse: optimize scatter-gather direct IO
Next Topic:	[PATCH v5 00/18] slab accounting for memcg

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Aug 26 09:20:13 GMT 2026

Total time taken to generate the page: 0.99331 seconds