OpenVZ Forum: Devel » [PATCH v3 04/13] kmem accounting basic infrastructure

Home » Mailing lists » Devel » [PATCH v3 04/13] kmem accounting basic infrastructure

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v3 04/13] kmem accounting basic infrastructure [message #48140 is a reply to message #48123]

Sun, 30 September 2012 08:23

Tejun Heo
Messages: 184
Registered: November 2006

Senior Member

Hello, Glauber.

On Thu, Sep 27, 2012 at 10:30:36PM +0400, Glauber Costa wrote:
> > But that happens only when pages enter and leave slab and if it still
> > is significant, we can try to further optimize charging. Given that
> > this is only for cases where memcg is already in use and we provide a
> > switch to disable it globally, I really don't think this warrants
> > implementing fully hierarchy configuration.
>
> Not totally true. We still have to match every allocation to the right
> cache, and that is actually our heaviest hit, responsible for the 2, 3 %
> we're seeing when this is enabled. It is the kind of path so hot that
> people frown upon branches being added, so I don't think we'll ever get
> this close to being free.

Sure, depening on workload, any addition to alloc/free could be
noticeable. I don't know. I'll write more about it when replying to
Michal's message. BTW, __memcg_kmem_get_cache() does seem a bit
heavy. I wonder whether indexing from cache side would make it
cheaper? e.g. something like the following.

kmem_cache *__memcg_kmem_get_cache(cachep, gfp)
{
struct kmem_cache *c;

c = cachep->memcg_params->caches[percpu_read(kmemcg_slab_idx)];
if (likely(c))
return c;
/* try to create and then fall back to cachep */
}

where kmemcg_slab_idx is updated from sched notifier (or maybe add and
use current->kmemcg_slab_idx?). You would still need __GFP_* and
in_interrupt() tests but current->mm and PF_KTHREAD tests can be
rolled into index selection.

Thanks.

--
tejun

Report message to a moderator

[Message index]

		[PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Tue, 18 September 2012 14:04
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Fri, 21 September 2012 16:34
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Mon, 24 September 2012 08:09
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Wed, 26 September 2012 14:03
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 14:33
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Wed, 26 September 2012 16:01
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 17:34
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 16:36
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 17:36
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 17:44
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 17:53
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 18:01
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 18:56
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 19:34
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 19:46
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 19:56
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 20:02
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 20:16
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 21:24
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 22:10
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 22:29
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 22:42
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 22:54
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 23:08
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 23:20
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 23:33
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Thu, 27 September 2012 12:15
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 27 September 2012 12:20
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Thu, 27 September 2012 12:40
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 27 September 2012 12:40
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Thu, 27 September 2012 12:54
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Mel Gorman on Thu, 27 September 2012 14:28
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Thu, 27 September 2012 14:49
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 27 September 2012 14:57
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Thu, 27 September 2012 17:46
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Thu, 27 September 2012 17:56
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 27 September 2012 18:45
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Sun, 30 September 2012 07:57
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Sun, 30 September 2012 08:02
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: James Bottomley on Sun, 30 September 2012 08:56
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Sun, 30 September 2012 10:37
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: James Bottomley on Sun, 30 September 2012 11:25
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Mon, 01 October 2012 00:57
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Mon, 01 October 2012 08:43
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Mon, 01 October 2012 08:46
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 03 October 2012 22:59
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Mon, 01 October 2012 08:36
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Thu, 27 September 2012 12:08
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 27 September 2012 12:11
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Thu, 27 September 2012 14:33
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Mel Gorman on Thu, 27 September 2012 14:43
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Thu, 27 September 2012 14:58
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 27 September 2012 18:30
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Sun, 30 September 2012 08:23
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Mon, 01 October 2012 08:45
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 03 October 2012 22:54
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 04 October 2012 11:55
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Sat, 06 October 2012 02:19
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Thu, 27 September 2012 15:09
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Sun, 30 September 2012 08:47
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Mon, 01 October 2012 09:27
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 03 October 2012 22:43
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Fri, 05 October 2012 13:47
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Johannes Weiner on Wed, 26 September 2012 22:11
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 22:45

Previous Topic:	[PATCH v3 00/16] slab accounting for memcg
Next Topic:	[RFC PATCH 0/5] net: socket bind to file descriptor introduced

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Nov 04 20:42:35 GMT 2024

Total time taken to generate the page: 0.03707 seconds