OpenVZ Forum: Devel » [PATCH v3 00/13] kmem controller for memcg.

Home » Mailing lists » Devel » [PATCH v3 00/13] kmem controller for memcg.

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v3 06/13] memcg: kmem controller infrastructure [message #48041 is a reply to message #47967]

Fri, 21 September 2012 09:14

JoonSoo Kim
Messages: 9
Registered: September 2012

Junior Member

>> "*_memcg = memcg" should be executed when "memcg_charge_kmem" is success.
>> "memcg_charge_kmem" return 0 if success in charging.
>> Therefore, I think this code is wrong.
>> If I am right, it is a serious bug that affect behavior of all the patchset.
>
> Which is precisely what it does. ret is a boolean, that will be true
> when charge succeeded (== 0 test)

Ahh...Okay! I didn't see (== 0 test)

Report message to a moderator

[Message index]

		[PATCH v3 00/13] kmem controller for memcg. By: Glauber Costa on Tue, 18 September 2012 14:03
		[PATCH v3 03/13] memcg: change defines to an enum By: Glauber Costa on Tue, 18 September 2012 14:04
		Re: [PATCH v3 03/13] memcg: change defines to an enum By: Johannes Weiner on Mon, 01 October 2012 19:06
		Re: [PATCH v3 03/13] memcg: change defines to an enum By: Glauber Costa on Tue, 02 October 2012 09:10
		[PATCH v3 12/13] execute the whole memcg freeing in rcu callback By: Glauber Costa on Tue, 18 September 2012 14:04
		Re: [PATCH v3 12/13] execute the whole memcg freeing in rcu callback By: Tejun Heo on Fri, 21 September 2012 17:23
		Re: [PATCH v3 12/13] execute the whole memcg freeing in rcu callback By: Glauber Costa on Mon, 24 September 2012 08:48
		Re: [PATCH v3 12/13] execute the whole memcg freeing in rcu callback By: Michal Hocko on Mon, 01 October 2012 13:27
		Re: [PATCH v3 12/13] execute the whole memcg freeing in rcu callback By: Glauber Costa on Thu, 04 October 2012 10:53
		Re: [PATCH v3 12/13] execute the whole memcg freeing in rcu callback By: Glauber Costa on Thu, 04 October 2012 14:20
		Re: [PATCH v3 12/13] execute the whole memcg freeing in rcu callback By: Johannes Weiner on Fri, 05 October 2012 15:31
		Re: [PATCH v3 12/13] execute the whole memcg freeing in rcu callback By: Glauber Costa on Mon, 08 October 2012 09:45
		[PATCH v3 01/13] memcg: Make it possible to use the stock for more than one page. By: Glauber Costa on Tue, 18 September 2012 14:03
		Re: [PATCH v3 01/13] memcg: Make it possible to use the stock for more than one page. By: Johannes Weiner on Mon, 01 October 2012 18:48
		[PATCH v3 07/13] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Tue, 18 September 2012 14:04
		Re: [PATCH v3 07/13] mm: Allocate kernel pages to the right memcg By: Mel Gorman on Thu, 27 September 2012 13:50
		Re: [PATCH v3 07/13] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Fri, 28 September 2012 09:43
		Re: [PATCH v3 07/13] mm: Allocate kernel pages to the right memcg By: Mel Gorman on Fri, 28 September 2012 13:28
		Re: [PATCH v3 07/13] mm: Allocate kernel pages to the right memcg By: Michal Hocko on Thu, 27 September 2012 13:52
		[PATCH v3 10/13] memcg: use static branches when code not in use By: Glauber Costa on Tue, 18 September 2012 14:04
		Re: [PATCH v3 10/13] memcg: use static branches when code not in use By: Michal Hocko on Mon, 01 October 2012 12:25
		Re: [PATCH v3 10/13] memcg: use static branches when code not in use By: Glauber Costa on Mon, 01 October 2012 12:27
		[PATCH v3 06/13] memcg: kmem controller infrastructure By: Glauber Costa on Tue, 18 September 2012 14:04
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Glauber Costa on Fri, 21 September 2012 08:41
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: JoonSoo Kim on Fri, 21 September 2012 09:14
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: JoonSoo Kim on Thu, 20 September 2012 16:05
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Michal Hocko on Wed, 26 September 2012 15:51
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Glauber Costa on Thu, 27 September 2012 11:31
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Michal Hocko on Thu, 27 September 2012 13:44
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Glauber Costa on Fri, 28 September 2012 11:34
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Tejun Heo on Sun, 30 September 2012 08:25
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Glauber Costa on Mon, 01 October 2012 08:28
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Tejun Heo on Wed, 03 October 2012 22:11
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Michal Hocko on Mon, 01 October 2012 09:44
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Michal Hocko on Mon, 01 October 2012 09:48
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Glauber Costa on Mon, 01 October 2012 10:09
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Michal Hocko on Mon, 01 October 2012 11:51
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Glauber Costa on Mon, 01 October 2012 11:51
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Michal Hocko on Mon, 01 October 2012 11:58
		Re: [PATCH v3 06/13] memcg: kmem controller infrastructure By: Glauber Costa on Mon, 01 October 2012 12:04
		[PATCH v3 11/13] memcg: allow a memcg with kmem charges to be destructed. By: Glauber Costa on Tue, 18 September 2012 14:04
		Re: [PATCH v3 11/13] memcg: allow a memcg with kmem charges to be destructed. By: Michal Hocko on Mon, 01 October 2012 12:30
		[PATCH v3 09/13] memcg: kmem accounting lifecycle management By: Glauber Costa on Tue, 18 September 2012 14:04
		Re: [PATCH v3 09/13] memcg: kmem accounting lifecycle management By: Michal Hocko on Mon, 01 October 2012 12:15
		Re: [PATCH v3 09/13] memcg: kmem accounting lifecycle management By: Glauber Costa on Mon, 01 October 2012 12:29
		Re: [PATCH v3 09/13] memcg: kmem accounting lifecycle management By: Michal Hocko on Mon, 01 October 2012 12:36
		Re: [PATCH v3 09/13] memcg: kmem accounting lifecycle management By: Glauber Costa on Mon, 01 October 2012 12:43
		[PATCH v3 05/13] Add a __GFP_KMEMCG flag By: Glauber Costa on Tue, 18 September 2012 14:04
		Re: [PATCH v3 05/13] Add a __GFP_KMEMCG flag By: Rik van Riel on Tue, 18 September 2012 14:15
		Re: [PATCH v3 05/13] Add a __GFP_KMEMCG flag By: Christoph Lameter on Tue, 18 September 2012 15:06
		Re: [PATCH v3 05/13] Add a __GFP_KMEMCG flag By: Glauber Costa on Wed, 19 September 2012 07:39
		Re: [PATCH v3 05/13] Add a __GFP_KMEMCG flag By: Christoph Lameter on Wed, 19 September 2012 14:07
		Re: [PATCH v3 05/13] Add a __GFP_KMEMCG flag By: Mel Gorman on Thu, 27 September 2012 13:34
		Re: [PATCH v3 05/13] Add a __GFP_KMEMCG flag By: Glauber Costa on Thu, 27 September 2012 13:41
		Re: [PATCH v3 05/13] Add a __GFP_KMEMCG flag By: Johannes Weiner on Mon, 01 October 2012 19:09
		[PATCH v3 13/13] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Glauber Costa on Tue, 18 September 2012 14:04
		Re: [PATCH v3 13/13] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Michal Hocko on Mon, 01 October 2012 13:17

Previous Topic:	[RFC PATCH 0/5] net: socket bind to file descriptor introduced
Next Topic:	[RFC] Posix timers improvements, requied for CRIU project

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Thu Aug 08 00:17:54 GMT 2024

Total time taken to generate the page: 0.02795 seconds