OpenVZ Forum: Devel » [PATCH v3 04/13] kmem accounting basic infrastructure

Home » Mailing lists » Devel » [PATCH v3 04/13] kmem accounting basic infrastructure

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v3 04/13] kmem accounting basic infrastructure [message #47977 is a reply to message #47884]

Fri, 21 September 2012 16:34

Tejun Heo
Messages: 184
Registered: November 2006

Senior Member

On Tue, Sep 18, 2012 at 06:04:01PM +0400, Glauber Costa wrote:
> #ifdef CONFIG_MEMCG_KMEM
> +static struct cftype kmem_cgroup_files[] = {
> + {
> + .name = "kmem.limit_in_bytes",
> + .private = MEMFILE_PRIVATE(_KMEM, RES_LIMIT),
> + .write_string = mem_cgroup_write,
> + .read = mem_cgroup_read,
> + },
> + {
> + .name = "kmem.usage_in_bytes",
> + .private = MEMFILE_PRIVATE(_KMEM, RES_USAGE),
> + .read = mem_cgroup_read,
> + },
> + {
> + .name = "kmem.failcnt",
> + .private = MEMFILE_PRIVATE(_KMEM, RES_FAILCNT),
> + .trigger = mem_cgroup_reset,
> + .read = mem_cgroup_read,
> + },
> + {
> + .name = "kmem.max_usage_in_bytes",
> + .private = MEMFILE_PRIVATE(_KMEM, RES_MAX_USAGE),
> + .trigger = mem_cgroup_reset,
> + .read = mem_cgroup_read,
> + },
> + {},
> +};
> +
> static int memcg_init_kmem(struct mem_cgroup *memcg, struct cgroup_subsys *ss)
> {
> return mem_cgroup_sockets_init(memcg, ss);
> @@ -4961,6 +5015,12 @@ mem_cgroup_create(struct cgroup *cont)
> int cpu;
> enable_swap_cgroup();
> parent = NULL;
> +
> +#ifdef CONFIG_MEMCG_KMEM
> + WARN_ON(cgroup_add_cftypes(&mem_cgroup_subsys,
> + kmem_cgroup_files));
> +#endif
> +

Why not just make it part of mem_cgroup_files[]?

Thanks.

--
tejun

Report message to a moderator

[Message index]

		[PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Tue, 18 September 2012 14:04
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Fri, 21 September 2012 16:34
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Mon, 24 September 2012 08:09
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Wed, 26 September 2012 14:03
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 14:33
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Wed, 26 September 2012 16:01
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 17:34
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 16:36
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 17:36
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 17:44
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 17:53
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 18:01
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 18:56
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 19:34
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 19:46
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 19:56
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 20:02
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 20:16
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 21:24
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 22:10
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 22:29
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 22:42
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 22:54
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 23:08
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 23:20
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 26 September 2012 23:33
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Thu, 27 September 2012 12:15
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 27 September 2012 12:20
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Thu, 27 September 2012 12:40
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 27 September 2012 12:40
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Thu, 27 September 2012 12:54
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Mel Gorman on Thu, 27 September 2012 14:28
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Thu, 27 September 2012 14:49
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 27 September 2012 14:57
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Thu, 27 September 2012 17:46
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Thu, 27 September 2012 17:56
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 27 September 2012 18:45
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Sun, 30 September 2012 07:57
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Sun, 30 September 2012 08:02
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: James Bottomley on Sun, 30 September 2012 08:56
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Sun, 30 September 2012 10:37
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: James Bottomley on Sun, 30 September 2012 11:25
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Mon, 01 October 2012 00:57
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Mon, 01 October 2012 08:43
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Mon, 01 October 2012 08:46
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 03 October 2012 22:59
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Mon, 01 October 2012 08:36
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Thu, 27 September 2012 12:08
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 27 September 2012 12:11
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Thu, 27 September 2012 14:33
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Mel Gorman on Thu, 27 September 2012 14:43
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Thu, 27 September 2012 14:58
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 27 September 2012 18:30
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Sun, 30 September 2012 08:23
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Mon, 01 October 2012 08:45
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 03 October 2012 22:54
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Thu, 04 October 2012 11:55
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Sat, 06 October 2012 02:19
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Thu, 27 September 2012 15:09
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Sun, 30 September 2012 08:47
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Mon, 01 October 2012 09:27
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Tejun Heo on Wed, 03 October 2012 22:43
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Michal Hocko on Fri, 05 October 2012 13:47
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Johannes Weiner on Wed, 26 September 2012 22:11
		Re: [PATCH v3 04/13] kmem accounting basic infrastructure By: Glauber Costa on Wed, 26 September 2012 22:45

Previous Topic:	[PATCH v3 00/16] slab accounting for memcg
Next Topic:	[RFC PATCH 0/5] net: socket bind to file descriptor introduced

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Aug 31 08:14:02 GMT 2025

Total time taken to generate the page: 0.07606 seconds