OpenVZ Forum: Devel » [PATCH 0/6] fuse: allocate req->pages[] dynamically

Home » Mailing lists » Devel » [PATCH 0/6] fuse: allocate req->pages[] dynamically

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 2/6] fuse: categorize fuse_get_req() [message #47812 is a reply to message #47759]

Wed, 12 September 2012 16:20

Miklos Szeredi
Messages: 161
Registered: April 2007

Senior Member

Maxim Patlasov <mpatlasov@parallels.com> writes:

> The patch categorizes all fuse_get_req() invocations into three categories:
> - fuse_get_req_nopages() - when caller doesn't care about req->pages
> - fuse_get_req_onepage() - when caller need exactly one page
> - fuse_get_req_multipage() - in other cases.

I think you are overcomplicating this.

Just have two functions: fuse_get_req_nopages() and fuse_get_req().

I don't think the _onepage variant deserves a separate helper.

Thanks,
Miklos

Report message to a moderator

[Message index]

		[PATCH 0/6] fuse: allocate req->pages[] dynamically By: Maxim Patlasov on Fri, 07 September 2012 17:40
		[PATCH 1/6] fuse: general infrastructure for pages[] of variable size By: Maxim Patlasov on Fri, 07 September 2012 17:41
		Re: [PATCH 1/6] fuse: general infrastructure for pages[] of variable size By: Miklos Szeredi on Wed, 12 September 2012 16:09
		[PATCH 2/6] fuse: categorize fuse_get_req() By: Maxim Patlasov on Fri, 07 September 2012 17:41
		Re: [PATCH 2/6] fuse: categorize fuse_get_req() By: Miklos Szeredi on Wed, 12 September 2012 16:20
		[PATCH 3/6] fuse: rework fuse_retrieve() By: Maxim Patlasov on Fri, 07 September 2012 17:41
		Re: [PATCH 3/6] fuse: rework fuse_retrieve() By: Miklos Szeredi on Wed, 12 September 2012 16:23
		[PATCH 4/6] fuse: rework fuse_readpages() By: Maxim Patlasov on Fri, 07 September 2012 17:41
		Re: [PATCH 4/6] fuse: rework fuse_readpages() By: Miklos Szeredi on Wed, 12 September 2012 16:41
		[PATCH 5/6] fuse: rework fuse_perform_write() By: Maxim Patlasov on Fri, 07 September 2012 17:41
		Re: [PATCH 5/6] fuse: rework fuse_perform_write() By: Miklos Szeredi on Wed, 12 September 2012 16:43
		[PATCH 6/6] fuse: rework fuse_do_ioctl() By: Maxim Patlasov on Fri, 07 September 2012 17:41
		Re: [PATCH 0/6] fuse: allocate req->pages[] dynamically By: Maxim Patlasov on Mon, 10 September 2012 10:18
		Re: [PATCH 0/6] fuse: allocate req->pages[] dynamically By: Maxim Patlasov on Wed, 12 September 2012 16:07
		Re: [PATCH 0/6] fuse: allocate req->pages[] dynamically By: Miklos Szeredi on Wed, 12 September 2012 16:49
		Re: [PATCH 0/6] fuse: allocate req->pages[] dynamically By: Maxim Patlasov on Fri, 14 September 2012 13:18
		Re: [PATCH 0/6] fuse: allocate req->pages[] dynamically By: Miklos Szeredi on Fri, 14 September 2012 14:39

Previous Topic:	[PATCH v2] SUNRPC: check current nsproxy before set of node name on client creation
Next Topic:	[PATCH 0/3] lockd: use per-net refrence-counted NSM clients

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Sep 12 18:55:03 GMT 2025

Total time taken to generate the page: 0.08542 seconds