OpenVZ Forum: Devel » [RFC PATCH 0/5] net: socket bind to file descriptor introduced

Home » Mailing lists » Devel » [RFC PATCH 0/5] net: socket bind to file descriptor introduced

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced [message #47560 is a reply to message #47535]

Thu, 16 August 2012 03:03

ebiederm
Messages: 1354
Registered: February 2006

Senior Member

Stanislav Kinsbursky <skinsbursky@parallels.com> writes:

> This patch set introduces new socket operation and new system call:
> sys_fbind(), which allows to bind socket to opened file.
> File to bind to can be created by sys_mknod(S_IFSOCK) and opened by
> open(O_PATH).
>
> This system call is especially required for UNIX sockets, which has name
> lenght limitation.
>
> The following series implements...

Hmm. I just realized this patchset is even sillier than I thought.

Stanislav is the problem you are ultimately trying to solve nfs clients
in a container connecting to the wrong user space rpciod?

Aka net/sunrpc/xprtsock.c:xs_setup_local only taking an absolute path
and then creating a delayed work item to actually open the unix domain
socket?

The straight correct and straight forward thing to do appears to be:
- Capture the root from current->fs in xs_setup_local.
- In xs_local_finish_connect change current->fs.root to the captured
version of root before kernel_connect, and restore current->fs.root
after kernel_connect.

It might not be a bad idea to implement open on unix domain sockets in
a filesystem as create(AF_LOCAL)+connect() which would allow you to
replace __sock_create + kernel_connect with a simple file_open_root.

But I think the simple scheme of:
struct path old_root;
old_root = current->fs.root;
kernel_connect(...);
current->fs.root = old_root;

Is more than sufficient and will remove the need for anything
except a purely local change to get nfs clients to connect from
containers.

Eric

Report message to a moderator

[Message index]

		[RFC PATCH 0/5] net: socket bind to file descriptor introduced By: Stanislav Kinsbursky on Wed, 15 August 2012 16:21
		[RFC PATCH 2/5] net: split unix_bind() By: Stanislav Kinsbursky on Wed, 15 August 2012 16:22
		[RFC PATCH 1/5] net: cleanup unix_bind() a little By: Stanislav Kinsbursky on Wed, 15 August 2012 16:22
		[RFC PATCH 3/5] net: new protocol operation fbind() introduced By: Stanislav Kinsbursky on Wed, 15 August 2012 16:22
		[RFC PATCH 4/5] net: fbind() for unix sockets protocol operations introduced By: Stanislav Kinsbursky on Wed, 15 August 2012 16:22
		[RFC PATCH 5/5] syscall: sys_fbind() introduced By: Stanislav Kinsbursky on Wed, 15 August 2012 16:22
		Re: [RFC PATCH 5/5] syscall: sys_fbind() introduced By: hpa on Wed, 15 August 2012 16:30
		Re: [RFC PATCH 5/5] syscall: sys_fbind() introduced By: Stanislav Kinsbursky on Wed, 15 August 2012 16:43
		Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced By: hpa on Wed, 15 August 2012 17:54
		Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced By: ebiederm on Wed, 15 August 2012 19:49
		Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced By: hpa on Wed, 15 August 2012 20:58
		Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced By: ebiederm on Wed, 15 August 2012 21:25
		Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced By: ebiederm on Thu, 16 August 2012 03:03
		Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced By: bfields on Thu, 16 August 2012 13:54
		Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced By: Stanislav Kinsbursky on Mon, 20 August 2012 10:18
		Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced By: bfields on Tue, 04 September 2012 19:00
		Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced By: bfields on Fri, 05 October 2012 20:00
		Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced By: Stanislav Kinsbursky on Mon, 08 October 2012 08:37
		Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced By: Ben Pfaff on Wed, 15 August 2012 16:52

Previous Topic:	[PATCH v3 04/13] kmem accounting basic infrastructure
Next Topic:	[PATCH v3 00/13] kmem controller for memcg.

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Jul 20 10:03:56 GMT 2025

Total time taken to generate the page: 0.07381 seconds